Hello. On Fri, 2014-07-18 at 14:37, Cedric BAIL wrote: > On Fri, Jul 18, 2014 at 1:41 PM, Lukasz Stanislawski > <l.stanisl...@samsung.com> wrote: > > W dniu 18.07.2014 12:10, Stefan Schmidt pisze: > >> Hello. > >> > >> On Tue, 2014-07-15 at 22:53, Tom Hacohen wrote: > >>> On 15/07/14 22:46, ryuan Choi wrote: > >>>> I compiled Elementary with tests and got below errors. > >>>> Some APIs look changed. > >>>> > >>>> What I did: > >>>> cd elementary > >>>> ./autogen.sh --prefix=/usr/elocal --with-tests=regular > >>>> make -j8 > >>>> sudo make install > >>>> make check -j8 > >>>> > >>>> Error message: > >>>> > >>>> elm_suite-elm_test_atspi.o: In function > >>>> `elm_test_atspi_object_children_get': > >>>> /home/ryuan/workspace/project/efl/elementary/src/tests/elm_test_atspi.c:262: > >>>> undefined reference to `_elm_atspi_root_get' > >>>> elm_suite-elm_test_atspi.o: In function `generate_app': > >>>> /home/ryuan/workspace/project/efl/elementary/src/tests/elm_test_atspi.c:35: > >>>> undefined reference to `_elm_atspi_init' > >>>> /home/ryuan/workspace/project/efl/elementary/src/tests/elm_test_atspi.c:37: > >>>> undefined reference to `_elm_atspi_root_get' > >>>> elm_suite-elm_test_entry.o: In function `elm_entry_atspi_text_text_get': > >>>> /home/ryuan/workspace/project/efl/elementary/src/tests/elm_test_entry.c:271: > >>>> undefined reference to `elm_interface_atspi_text_text_get' > >>>> > >>>> Best Regards, > >>>> Ryuan Choi > >>>> ------------------------------------------------------------------------------ > >>>> Want fast and easy access to all the code in your enterprise? Index and > >>>> search up to 200,000 lines of code with a free copy of Black Duck > >>>> Code Sight - the same software that powers the world's largest code > >>>> search on Ohloh, the Black Duck Open Hub! Try it now. > >>>> http://p.sf.net/sfu/bds > >>>> _______________________________________________ > >>>> enlightenment-devel mailing list > >>>> enlightenment-devel@lists.sourceforge.net > >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >>>> > >>> Hey, > >>> > >>> I fixed the issue with the entry test, thanks for reporting. No idea > >>> about the rest. Can't find those functions or any trace of them, and > >>> don't really have the time to try and find them in history. It would be > >>> great if whoever who wrote it will fix it. > >>> > >>> Stefan: don't we "make check" for elementary on jenkins? I wonder how > >>> this was missed for so long. > >> Took me a moment as I was on some training. > >> > >> We run make check but what we never did was actually configuring elm > >> with regular tests. I changed this now and it is segfaulting nicely on > >> jenkins. If anyone wants to have a look. > >> > >> https://build.enlightenment.org/job/changely_elm_gcc_x86_64/ws/src/tests/test-suite.log > > Hi Stefan, > > > > After quick invastigation it looks like segmentation faults may be > > caused by failures in setting elm objects text parts. Generally, all > > test cases doesn't assume that > > setting texts with elm_object_text_set method may fail and make string > > comparison directly on elm_object_text_get return value. > > I can add additonal NULL checks but all-in-all this tests will fail. > > > > It looks like elementary is unable to properly initialize without > > xserver running or because there is no desktop attached.(there are some > > log entries related to undefined desktop environmental variable). I'm > > not getting sigsegv on my local machine. > > I did try to test it on my computer and I get also some failure : > 77%: Checks: 99, Failures: 21, Errors: 1 > elm_test_entry.c:203:F:elm_entry:elm_entry_atspi_text_string_get_paragraph:0: > Assertion 'val==" dolor sit"' failed: val==" dolor sit amęt", " > dolor sit"==" dolor sit" > elm_test_entry.c:242:F:elm_entry:elm_entry_atspi_text_string_get_line:0: > Assertion 'val=="Lorem ipśum"' failed: val=="Lorem", "Lorem > ipśum"=="Lorem ipśum" > elm_test_entry.c:272:F:elm_entry:elm_entry_atspi_text_text_get:0: > Assertion 'val==txtnom' failed: val=="Lorem ip", txtnom=="Lorem ipśum > dolor sit > amęt" > elm_test_atspi.c:36:E:elm_atspi:elm_atspi_name_get:0: (after this > point) Received signal 11 (Segmentation fault) > elm_test_atspi.c:64:F:elm_atspi:elm_atspi_role_get:0: Assertion 'role > == ELM_ATSPI_ROLE_APPLICATION' failed > elm_test_atspi.c:81:F:elm_atspi:elm_atspi_role_name_get:0: Assertion > 'ret != ((void *)0)' failed > elm_test_atspi.c:97:F:elm_atspi:elm_atspi_localized_role_name_get:0: > Assertion 'ret != ((void *)0)' failed > elm_test_atspi.c:121:F:elm_atspi:elm_atspi_description_set:0: > Assertion 'ret != ((void *)0)' failed > elm_test_atspi.c:140:F:elm_atspi:elm_atspi_children_and_parent:0: > Assertion 'eina_list_count(child_list) == 1' failed > elm_test_atspi.c:176:F:elm_atspi:elm_atspi_component_position:0: > Assertion 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:205:F:elm_atspi:elm_atspi_component_size:0: Assertion > 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:234:F:elm_atspi:elm_atspi_component_focus:0: > Assertion 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:269:F:elm_atspi:elm_test_atspi_obj_index_in_parent_get:0: > Assertion 'win != ((void *)0)' failed > elm_test_atspi.c:362:F:elm_atspi:elm_atspi_children_and_parent2:0: > Assertion 'eina_list_count(win_children) == 2' failed > elm_test_list.c:32:F:elm_list:elm_list_atspi_selection_selected_children_count_get:0: > Assertion 'val == 1' failed > elm_test_list.c:55:F:elm_list:elm_list_atspi_selection_child_select:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:78:F:elm_list:elm_list_atspi_selection_selected_child_deselect:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:102:F:elm_list:elm_list_atspi_selection_is_child_selected:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:127:F:elm_list:elm_list_atspi_selection_all_children_select:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:154:F:elm_list:elm_list_atspi_selection_clear:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:178:F:elm_list:elm_list_atspi_selection_child_deselect:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_win.c:23:F:elm_win:elm_atspi_role_get:0: Assertion 'role == > ELM_ATSPI_ROLE_WINDOW' failed > > Also if I do "unset DISPLAY" before running the tests suite, I get the > following issue after a very long time (there is a huge delay that > seems related to scim not finding a DISPLAY) : > 77%: Checks: 99, Failures: 21, Errors: 1 > elm_test_entry.c:203:F:elm_entry:elm_entry_atspi_text_string_get_paragraph:0: > Assertion 'val==" dolor sit"' failed: val==" dolor sit amęt", " > dolor sit"==" dolor sit" > elm_test_entry.c:242:F:elm_entry:elm_entry_atspi_text_string_get_line:0: > Assertion 'val=="Lorem ipśum"' failed: val=="Lorem", "Lorem > ipśum"=="Lorem ipśum" > elm_test_entry.c:272:F:elm_entry:elm_entry_atspi_text_text_get:0: > Assertion 'val==txtnom' failed: val=="Lorem ip", txtnom=="Lorem ipśum > dolor sit > amęt" > elm_test_atspi.c:36:E:elm_atspi:elm_atspi_name_get:0: (after this > point) Received signal 11 (Segmentation fault) > elm_test_atspi.c:64:F:elm_atspi:elm_atspi_role_get:0: Assertion 'role > == ELM_ATSPI_ROLE_APPLICATION' failed > elm_test_atspi.c:81:F:elm_atspi:elm_atspi_role_name_get:0: Assertion > 'ret != ((void *)0)' failed > elm_test_atspi.c:97:F:elm_atspi:elm_atspi_localized_role_name_get:0: > Assertion 'ret != ((void *)0)' failed > elm_test_atspi.c:121:F:elm_atspi:elm_atspi_description_set:0: > Assertion 'ret != ((void *)0)' failed > elm_test_atspi.c:140:F:elm_atspi:elm_atspi_children_and_parent:0: > Assertion 'eina_list_count(child_list) == 1' failed > elm_test_atspi.c:176:F:elm_atspi:elm_atspi_component_position:0: > Assertion 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:205:F:elm_atspi:elm_atspi_component_size:0: Assertion > 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:234:F:elm_atspi:elm_atspi_component_focus:0: > Assertion 'ret == ((Eina_Bool)1)' failed > elm_test_atspi.c:269:F:elm_atspi:elm_test_atspi_obj_index_in_parent_get:0: > Assertion 'win != ((void *)0)' failed > elm_test_atspi.c:362:F:elm_atspi:elm_atspi_children_and_parent2:0: > Assertion 'eina_list_count(win_children) == 2' failed > elm_test_list.c:32:F:elm_list:elm_list_atspi_selection_selected_children_count_get:0: > Assertion 'val == 1' failed > elm_test_list.c:55:F:elm_list:elm_list_atspi_selection_child_select:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:78:F:elm_list:elm_list_atspi_selection_selected_child_deselect:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:102:F:elm_list:elm_list_atspi_selection_is_child_selected:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:127:F:elm_list:elm_list_atspi_selection_all_children_select:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:154:F:elm_list:elm_list_atspi_selection_clear:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_list.c:178:F:elm_list:elm_list_atspi_selection_child_deselect:0: > Assertion 'val == ((Eina_Bool)1)' failed > elm_test_win.c:23:F:elm_win:elm_atspi_role_get:0: Assertion 'role == > ELM_ATSPI_ROLE_WINDOW' failed > > Seems to me it is not related to X, but more to atspi.
I was looking into this with the hope to have it enabled for the 1.11 release. My findings are interesting. Doing a configure with --with-tests=regular let me run make check in elm and succeed. When trying to run it as part of make distcheck (after fixing a mising header) I run into the problems with segfaults and the same assertions from above again. So something is fishy here when running the test suite not from the normal in src path. Is there anything it relays on? To enable check for make distcheck you need to add AM_DISTCHECK_CONFIGURE_FLAGS = with-tests=regular on the top of the main Makefile.am That is how we ensure it is running for efl and I would like to have the same setup for elm. regards Stefan Schmidt ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
