2014-08-17 2:30 GMT+03:00 Kai Huuhko <[email protected]>:
> 2014-08-16 23:14 GMT+03:00 Davide Andreoli <[email protected]>:
>> 2014-08-16 15:50 GMT+02:00 Kai Huuhko <[email protected]>:
>>
>>> kuuko pushed a commit to branch master.
>>>
>>>
>>> http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=a1140f96416ffedb6b59b388fbed7ee18754e536
>>>
>>> commit a1140f96416ffedb6b59b388fbed7ee18754e536
>>> Author: Kai Huuhko <[email protected]>
>>> Date: Sat Aug 16 16:50:06 2014 +0300
>>>
>>> setup.py: add missing ecore-x include dir for elm
>>>
>>
>>
>> This seems wrong to me.
>> It breaks compilation if you don't have ecore-x and is not necessary on my
>> machines...
>> you need to fix your environment :P
>>
>
> It is correct though since we have
Damned CTRL-Return shortcut...
since we have this in window.pxd:
cdef extern from "Ecore_X.h":
ctypedef unsigned int Ecore_X_ID
ctypedef Ecore_X_ID Ecore_X_Window
It will fail to build either implicitly or explicitly when ecore-x is
not in include dirs.
One solution is to make those definitions platform specific, which we
can do with
http://docs.cython.org/src/reference/language_basics.html#compile-time-definitions
Since X support can be disabled with configure options for EFL, we
should really use pkg-config to get the option value and somehow make
the code conditional based on that. Any suggestions?
>
>
>>
>>> ---
>>> setup.py | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/setup.py b/setup.py
>>> index 2e48c24..c3e5ce0 100755
>>> --- a/setup.py
>>> +++ b/setup.py
>>> @@ -410,7 +410,7 @@ if set(("build", "build_ext", "install", "bdist",
>>> "sdist")) & set(sys.argv):
>>> "elementary." + m,
>>> ["efl/elementary/" + m + module_suffix],
>>> include_dirs=["include/"],
>>> - extra_compile_args=elm_cflags,
>>> + extra_compile_args=elm_cflags + ecore_x_cflags,
>>> extra_link_args=elm_libs + eina_libs + evas_libs,
>>> )
>>> modules.append(e)
>>>
>>> --
>>>
>>>
>>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> enlightenment-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
