I left the problem in the comment. " Application could use their own text domain." But the origin code seems remove the locale with this. const char *msg_locale = setlocale(LC_MESSAGES, NULL); As far as your commit message, you should describe the reason why the code is correct and my revert is wrong. ------------------------------------
-Regards, Hermet- -----Original Message----- From: "Tom Hacohen"<t...@stosb.com> To: <g...@lists.enlightenment.org>; Cc: Sent: 2014-08-26 (화) 20:09:29 Subject: [EGIT] [core/elementary] master 01/01: Revert "elementary/config - commented out the translation availabilty check." tasn pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=89d58d8f2f0116f19700fe729681bc1c31c0df24 commit 89d58d8f2f0116f19700fe729681bc1c31c0df24 Author: Tom Hacohen <tom>@stosb.com> Date: Tue Aug 26 12:07:53 2014 +0100 Revert "elementary/config - commented out the translation availabilty check." This completely breaks automatic UI mirroring. The code there was correct. Please, before removing code, contact the original author and make sure you don't break things down. Especially if your reason for removing is "this doesn't make sense to me" instead of "this breaks X Y." This reverts commit 24983fed239a3b37c05cc3c65ed9c56953a7176b. --- src/lib/elm_config.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/lib/elm_config.c b/src/lib/elm_config.c index 65cb2f2..7c72e93 100644 --- a/src/lib/elm_config.c +++ b/src/lib/elm_config.c @@ -3200,15 +3200,9 @@ static void _translation_init() { #ifdef ENABLE_NLS - - /* How does it decide translation with current domain?? - Application could use their own text domain. - This is insane to me. - const char *cur_dom = textdomain(NULL); const char *trans_comment = gettext(""); const char *msg_locale = setlocale(LC_MESSAGES, NULL); - */ /* Same concept as what glib does: * We shouldn't translate if there are no translations for the @@ -3216,11 +3210,9 @@ _translation_init() * en_/C where translating only parts of the interface make some * sense). */ - /* - _elm_config->translate = !(strcmp (cur_dom, "messages") && - !*trans_comment && strncmp (msg_locale, "en_", 3) && - strcmp (msg_locale, "C")); - */ + _elm_config->translate = !(strcmp (cur_dom, "messages") && + !*trans_comment && strncmp (msg_locale, "en_", 3) && + strcmp (msg_locale, "C")); /* Get RTL orientation from system */ if (_elm_config->translate) { -- ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
