On 01/09/14 12:20, David Seikel wrote: > On Mon, 01 Sep 2014 10:36:42 +0100 Tom Hacohen > <[email protected]> wrote: > >> This is the worst bug report ever, and a stupid revert. >> >> First of all, when reverting, please list the commits being reverted >> because unlike what you said, you didn't revert all of them. Second >> of all, I assume you are talking about the one small issue with >> thumbnailing not working, which hardly means it's "completely >> broken". If there's anything else, please report, because I don't >> know of any. I obviously tested stuff, this one went unnoticed, and I >> already said I was working on fixing it. >> Also, you reverted unrelated commits that don't break the thumbnails >> in efm, more specifically, the last one you reverted. >> f6156c9a6234237757b61960c690e8d55779e764 > > I was also wondering in what way it was "completely broken". I was > running the pre reverted version, and ecore-con was working fine for > me in my application that uses it. >
After looking into it a bit deeper, all of the commmits he reverted, except for one, had nothing to do with it. It's just one that is broken, and only in some more specific case (which confused me at first when trying to find out the broken one). -- Tom >> -- >> Tom. >> >> On 30/08/14 13:13, Mike Blumenkrantz wrote: >>> discomfitor pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/efl.git/commit/?id=7b0db79c2d014bb2f1ed8dfbbb04ba291baad8f7 >>> >>> commit 7b0db79c2d014bb2f1ed8dfbbb04ba291baad8f7 >>> Author: Mike Blumenkrantz <[email protected]> >>> Date: Sat Aug 30 08:00:47 2014 -0400 >>> >>> revert all recent ecore-con related eo changes. completely >>> broken. >>> >>> please test things before committing. >>> >>> reverts all changes since and including >>> f6156c9a6234237757b61960c690e8d55779e764 --- >>> src/Makefile_Ecore_Con.am | 14 +- >>> src/lib/ecore_con/Ecore_Con.h | 27 +- >>> src/lib/ecore_con/Ecore_Con_Eo.h | 2 - >>> src/lib/ecore_con/Ecore_Con_Legacy.h | 2 - >>> src/lib/ecore_con/ecore_con.c | 138 +++------ >>> src/lib/ecore_con/ecore_con_base.eo | 7 +- >>> src/lib/ecore_con/ecore_con_connector.eo | 8 - >>> src/lib/ecore_con/ecore_con_private.h | 27 ++ >>> src/lib/ecore_con/ecore_con_server.eo | 18 +- >>> src/lib/ecore_con/ecore_con_url.c | 496 >>> ++++++++++++++++--------------- >>> src/lib/ecore_con/ecore_con_url.eo | 25 -- 11 files changed, >>> 352 insertions(+), 412 deletions(-) >>> > > > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > > > > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
