tasn pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f5e24c3bcf8ce594ad187e1bc447fc834ac8a252
commit f5e24c3bcf8ce594ad187e1bc447fc834ac8a252 Author: Marcel Hollerbach <[email protected]> Date: Fri Sep 19 02:16:37 2014 +0100 ecore_con: Fix error goto, scope data should not be freed Summary: If the function jumpes to the error, the scope data is freed, this is wrong, just the object should be destroyed, so not free, just eo_unref the object. Cause the object is just added above the object ref count should get 0 and obj will get removed Test Plan: Use the ecore_con_server_client_limit_set function and set the max count to 1, at the connect of a second client the server will fail at this free. Reviewers: tasn Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D1459 --- src/lib/ecore_con/ecore_con.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore_con/ecore_con.c b/src/lib/ecore_con/ecore_con.c index b5980ed..8e29d4d 100644 --- a/src/lib/ecore_con/ecore_con.c +++ b/src/lib/ecore_con/ecore_con.c @@ -2041,7 +2041,7 @@ error: ecore_event_del(ev); } } - free(cl); + eo_del(obj); if (clerr || errno) ecore_con_event_server_error(svr_obj, clerr ? : strerror(errno)); return ECORE_CALLBACK_RENEW; } --
