cedric pushed a commit to branch efl-1.11.

http://git.enlightenment.org/core/efl.git/commit/?id=88956a3037161a31539cc4bfe3693fe85f8da2a2

commit 88956a3037161a31539cc4bfe3693fe85f8da2a2
Author: Cedric BAIL <[email protected]>
Date:   Tue Sep 23 18:03:02 2014 +0200

    edje: fix borked edje_external.
    
    Someone fixed a CID without looking of the full use path a data, resulting
    in a value being used after free and stored in edje file. Leading to a 
garbage
    string with no meaning for those poor externals.
---
 src/bin/edje/edje_cc_handlers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/bin/edje/edje_cc_handlers.c b/src/bin/edje/edje_cc_handlers.c
index 41331ca..577b5c6 100644
--- a/src/bin/edje/edje_cc_handlers.c
+++ b/src/bin/edje/edje_cc_handlers.c
@@ -9859,6 +9859,7 @@ 
_st_collections_group_parts_part_description_params(Edje_External_Param_Type typ
        if (!strcmp(param->name, name))
          {
             found = 1;
+             free(name);
             break;
          }
      }
@@ -9895,8 +9896,6 @@ 
_st_collections_group_parts_part_description_params(Edje_External_Param_Type typ
 
    if (!found)
      ed->external_params = eina_list_append(ed->external_params, param);
-
-   free(name);
 }
 
 /**

-- 


Reply via email to