On Thu, 25 Sep 2014 15:33:12 +0100 Tom Hacohen <[email protected]> said:
> Luckily, it's an API break, and not an ABI break. > > To be honest, I'm just surprised someone is using Eo outside of the efl > as it can break. For example, the lines you change will 100% break > again, as we are going to change that elm class... k-s wrote that and used the eo api. maybe it should just be disabled in terminology until eo is stable... i think i'll do that. > -- > Tom. > > On 25/09/14 15:30, Christopher Michael wrote: > > devilhorns pushed a commit to branch master. > > > > http://git.enlightenment.org/apps/terminology.git/commit/?id=b6b89ba9112e455f8454c6f003431230d92ef139 > > > > commit b6b89ba9112e455f8454c6f003431230d92ef139 > > Author: Chris Michael <[email protected]> > > Date: Thu Sep 25 10:29:45 2014 -0400 > > > > terminology: Fix build break caused by > > 6846978ebd027fff1de57d526071517243354354 > > > > Summary: Fix build break from a TAsn efl change removing eo_add_custom > > function. > > > > @fix > > > > Signed-off-by: Chris Michael <[email protected]> > > --- > > src/bin/app_server.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/src/bin/app_server.c b/src/bin/app_server.c > > index 32a7855..c696914 100644 > > --- a/src/bin/app_server.c > > +++ b/src/bin/app_server.c > > @@ -287,8 +287,8 @@ _app_server_term_add(Term *term) > > if (_ignore_term_add) > > return NULL; > > > > - view = eo_add_custom(ELM_APP_SERVER_VIEW_CLASS, _server, > > - elm_app_server_view_constructor(NULL)); > > + view = eo_add(ELM_APP_SERVER_VIEW_CLASS, _server, > > + elm_app_server_view_constructor(NULL)); > > > > term_object = main_term_evas_object_get(term); > > > > @@ -402,10 +402,10 @@ app_server_init(Eina_List **wins, Eina_Bool > > restore_views) title = elm_win_title_get(main_win_evas_object_get(wn)); > > > > > > - _server = eo_add_custom(ELM_APP_SERVER_CLASS, NULL, > > - elm_app_server_constructor( > > - "org.enlightenment.Terminology", > > - _app_server_create_view_cb)); > > + _server = eo_add(ELM_APP_SERVER_CLASS, NULL, > > + elm_app_server_constructor( > > + > > "org.enlightenment.Terminology", > > + > > _app_server_create_view_cb)); > > > > eo_do(_server, elm_app_server_title_set(title), > > eo_key_data_set("wins", wins, NULL), > > > > > > ------------------------------------------------------------------------------ > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer > http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
