On 26/09/14 09:52, Tom Hacohen wrote: > GRRRRR, you are right, I need to find a better way to fix it. The other > way was wrong too. Would get into an infinite loop if the win is > referenced. This was true before eo too (evas_object_ref)...
Fixed. > > -- > Tom. > > On 26/09/14 00:09, Carsten Haitzler (The Rasterman) wrote: >> On Thu, 25 Sep 2014 09:39:51 -0700 Tom Hacohen <[email protected]> said: >> >> i do hope you never hit a situation where you add 2 windows... where deleting >> one window happens to call a del callback on the win object that deletes a >> companion dialog window.... that happens to be next win in the list... :) >> >>> tasn pushed a commit to branch master. >>> >>> http://git.enlightenment.org/core/elementary.git/commit/?id=6e7686c030fab162edb3128de005ec00ea8c0ffc >>> >>> commit 6e7686c030fab162edb3128de005ec00ea8c0ffc >>> Author: Tom Hacohen <[email protected]> >>> Date: Thu Sep 25 17:14:27 2014 +0100 >>> >>> Elm win: Fixed wrong deletion of win objects. >>> >>> Some of them may be reference still, you don't want to do this. >>> --- >>> src/lib/elm_win.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c >>> index 54d1853..c77482f 100644 >>> --- a/src/lib/elm_win.c >>> +++ b/src/lib/elm_win.c >>> @@ -2105,7 +2105,10 @@ _elm_win_on_resize_obj_changed_size_hints(void *data, >>> void >>> _elm_win_shutdown(void) >>> { >>> - while (_elm_win_list) evas_object_del(_elm_win_list->data); >>> + Eina_List *itr, *itrn; >>> + Evas_Object *obj; >>> + EINA_LIST_FOREACH_SAFE(_elm_win_list, itr, itrn, obj) >>> + evas_object_del(obj); >>> ELM_SAFE_FREE(_elm_win_state_eval_job, ecore_job_del); >>> } >>> >>> >>> -- >>> >>> >> >> > > > > ------------------------------------------------------------------------------ > Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer > Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports > Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper > Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer > http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
