cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=08521b77ec82cde9ca6708daa9c5aecfebb7c63c
commit 08521b77ec82cde9ca6708daa9c5aecfebb7c63c Author: Cedric BAIL <[email protected]> Date: Tue Sep 30 18:19:15 2014 +0200 ecore_evas: let's be consistent and always report an error. --- src/modules/ecore_evas/engines/x/ecore_evas_x.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/modules/ecore_evas/engines/x/ecore_evas_x.c b/src/modules/ecore_evas/engines/x/ecore_evas_x.c index ab3f571..5bd821c 100644 --- a/src/modules/ecore_evas/engines/x/ecore_evas_x.c +++ b/src/modules/ecore_evas/engines/x/ecore_evas_x.c @@ -3128,7 +3128,10 @@ _ecore_evas_x_reinit_win(Ecore_Evas *ee) if (einfo) { einfo->info.drawable = ee->prop.window; - evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo); + if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) + { + ERR("evas_engine_info_set() for engine '%s' failed.", ee->driver); + } } #endif } @@ -3141,7 +3144,10 @@ _ecore_evas_x_reinit_win(Ecore_Evas *ee) if (einfo) { einfo->info.drawable = ee->prop.window; - evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo); + if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) + { + ERR("evas_engine_info_set() for engine '%s' failed.", ee->driver); + } } #endif } @@ -3966,7 +3972,7 @@ ecore_evas_software_x11_new_internal(const char *disp_name, Ecore_X_Window paren einfo->info.debug = redraw_debug; if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) { - WRN("evas_engine_info_set() init engine '%s' failed.", ee->driver); + ERR("evas_engine_info_set() init engine '%s' failed.", ee->driver); ecore_evas_free(ee); return NULL; } @@ -4187,7 +4193,7 @@ ecore_evas_software_x11_pixmap_new_internal(const char *disp_name, Ecore_X_Windo if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) { - WRN("evas_engine_info_set() init engine '%s' failed.", ee->driver); + ERR("evas_engine_info_set() init engine '%s' failed.", ee->driver); ecore_evas_free(ee); return NULL; } @@ -4409,7 +4415,7 @@ ecore_evas_gl_x11_options_new_internal(const char *disp_name, Ecore_X_Window par (ee, edata->win_root, x, y, w, h, 0, 0, opt); if (!ee->prop.window) { - WRN("evas_engine_info_set() init engine '%s' failed.", ee->driver); + ERR("evas_engine_info_set() init engine '%s' failed.", ee->driver); ecore_evas_free(ee); return NULL; } @@ -4616,7 +4622,7 @@ ecore_evas_gl_x11_pixmap_new_internal(const char *disp_name, Ecore_X_Window pare if (!evas_engine_info_set(ee->evas, (Evas_Engine_Info *)einfo)) { - WRN("evas_engine_info_set() init engine '%s' failed.", ee->driver); + ERR("evas_engine_info_set() init engine '%s' failed.", ee->driver); ecore_evas_free(ee); return NULL; } --
