devilhorns pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=cfea1e93220231f9676e27c9bf923656916f36d7

commit cfea1e93220231f9676e27c9bf923656916f36d7
Author: Chris Michael <[email protected]>
Date:   Mon Oct 6 10:07:22 2014 -0400

    Revert verifying anything passed in to the API.
    
    Revert "ecore_drm: Verifying if name format is /dev/xyz before assigning to 
tty."
    
    This reverts commit 5ebc31908e7ac81a8f6ce0979a40ba7865a5bf48.
---
 src/lib/ecore_drm/ecore_drm_tty.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/lib/ecore_drm/ecore_drm_tty.c 
b/src/lib/ecore_drm/ecore_drm_tty.c
index c624698..c047494 100644
--- a/src/lib/ecore_drm/ecore_drm_tty.c
+++ b/src/lib/ecore_drm/ecore_drm_tty.c
@@ -205,13 +205,8 @@ ecore_drm_tty_open(Ecore_Drm_Device *dev, const char *name)
         else
           dev->tty.fd = dup(STDIN_FILENO);
      }
-   else
-     {
-        if (strncmp(name,"/dev/", 5))
-          snprintf(tty, sizeof(tty), "/dev/%s",name);
-        else
-          snprintf(tty, sizeof(tty), "%s", name);
-     }
+   else // FIXME: NB: This should Really check for format of name (/dev/xyz)
+     snprintf(tty, sizeof(tty), "%s", name);
 
    if (dev->tty.fd < 0)
      {

-- 


Reply via email to