On Tue, Oct 7, 2014 at 9:09 PM, Massimo Maiurana <[email protected]> wrote:

> I don't know why this line is in elementary/src/lib/elm_config.c:3207,
> but it makes gettext to localize the empty string with the content of
> the header of po files, which is of course wrong:
> const char *trans_comment = gettext("");
>
>
This is not wrong. This is exactly what's intended.

Git blame would have showed you the information about the commit and why
it's there. The name of the var also indicates that this is intended, it
does say "trans_comment" which is what it gets. :)

This is actually a horrible hack, also done by GTK+ and for all I know Qt
as well. It tries to translate "" using the default domain, which in
gettext land, as you have noticed means the translation header. However, if
the default domain is not set, or the application is not translated to the
current locale, it's not translated. This essentially lets us check if the
application is translated or not, so we can only apply ui mirroring and
translation of library strings if the application itself is translated.

I hope this clarifies things. Guys, use git blame, those are the best
comments you can get for code without littering the code with old outdated
comments. :)

--
Tom.
------------------------------------------------------------------------------
Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer
Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports
Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper
Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer
http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to