Hello,

>> cedric pushed a commit to branch master.
>>
>> http://git.enlightenment.org/core/efl.git/commit/?id=65db5e981b8f1b749d883469d617c0e2e8c70b89
>>
>> commit 65db5e981b8f1b749d883469d617c0e2e8c70b89
>> Author: Pierre Le Magourou <pierre.lemagou...@openwide.fr>
>> Date:   Fri Oct 17 15:32:44 2014 +0200
>>
>>     eldbus: add missing API documentation in Eldbus.h.
>> ---
>>  src/lib/eldbus/Eldbus.h | 50 
>> ++++++++++++++++++++++++++++++++-----------------
>>  1 file changed, 33 insertions(+), 17 deletions(-)
>>
>> diff --git a/src/lib/eldbus/Eldbus.h b/src/lib/eldbus/Eldbus.h
>> index 220d4ec..3e51b3d 100644
>> --- a/src/lib/eldbus/Eldbus.h
>> +++ b/src/lib/eldbus/Eldbus.h
>> @@ -116,18 +116,18 @@ extern "C" {
>>   *
>>   * @{
>>   */
>> -#define ELDBUS_VERSION_MAJOR EFL_VERSION_MAJOR
>> -#define ELDBUS_VERSION_MINOR EFL_VERSION_MINOR
>> -
>> -#define ELDBUS_FDO_BUS "org.freedesktop.DBus"
>> -#define ELDBUS_FDO_PATH "/org/freedesktop/DBus"
>> -#define ELDBUS_FDO_INTERFACE ELDBUS_FDO_BUS
>> -#define ELDBUS_FDO_INTERFACE_PROPERTIES "org.freedesktop.DBus.Properties"
>> -#define ELDBUS_FDO_INTERFACE_OBJECT_MANAGER 
>> "org.freedesktop.DBus.ObjectManager"
>> -#define ELDBUS_FDO_INTERFACE_INTROSPECTABLE 
>> "org.freedesktop.DBus.Introspectable"
>> -#define ELDBUS_FDO_INTEFACE_PEER "org.freedesktop.DBus.Peer"
>> -#define ELDBUS_ERROR_PENDING_CANCELED "org.enlightenment.DBus.Canceled"
>> -#define ELDBUS_ERROR_PENDING_TIMEOUT "org.freedesktop.DBus.Error.NoReply"
>> +#define ELDBUS_VERSION_MAJOR EFL_VERSION_MAJOR /**< Eldbus version major 
>> number */
>> +#define ELDBUS_VERSION_MINOR EFL_VERSION_MINOR /**< Eldbus version minor 
>> number */
>> +
>> +#define ELDBUS_FDO_BUS "org.freedesktop.DBus" /**< Eldbus bus name */
> 
> Are you using some tool to generate this?
> Because org.freedesktop.DBus is not a 'Eldbus bus name', also the
> other below are wrong too.

Yes, I did it wrong. Sorry about that.

>> +#define ELDBUS_FDO_PATH "/org/freedesktop/DBus" /**< Eldbus path name */
>> +#define ELDBUS_FDO_INTERFACE ELDBUS_FDO_BUS /**< Eldbus interface name */
>> +#define ELDBUS_FDO_INTERFACE_PROPERTIES "org.freedesktop.DBus.Properties" 
>> /**< Eldbus object properties request name */
>> +#define ELDBUS_FDO_INTERFACE_OBJECT_MANAGER 
>> "org.freedesktop.DBus.ObjectManager" /**< Eldbus object manager request name 
>> */
>> +#define ELDBUS_FDO_INTERFACE_INTROSPECTABLE 
>> "org.freedesktop.DBus.Introspectable" /**< Eldbus object introspect request 
>> name */
>> +#define ELDBUS_FDO_INTEFACE_PEER "org.freedesktop.DBus.Peer" /**< Eldbus 
>> object peer request name */
>> +#define ELDBUS_ERROR_PENDING_CANCELED "org.enlightenment.DBus.Canceled" 
>> /**< Eldbus canceled answer */
>> +#define ELDBUS_ERROR_PENDING_TIMEOUT "org.freedesktop.DBus.Error.NoReply" 
>> /**< Eldbus timeout error answer */
>>

Would this be better ?

#define ELDBUS_FDO_BUS "org.freedesktop.DBus" /**< DBus message bus name */
#define ELDBUS_FDO_PATH "/org/freedesktop/DBus" /**< Object that implements 
message bus interface */
#define ELDBUS_FDO_INTERFACE ELDBUS_FDO_BUS /**< DBus message bus interface */
#define ELDBUS_FDO_INTERFACE_PROPERTIES "org.freedesktop.DBus.Properties" /**< 
DBus Properties interface */
#define ELDBUS_FDO_INTERFACE_OBJECT_MANAGER 
"org.freedesktop.DBus.ObjectManager" /**< DBus ObjectManager interface */
#define ELDBUS_FDO_INTERFACE_INTROSPECTABLE 
"org.freedesktop.DBus.Introspectable" /**< DBus Introspectable interface */
#define ELDBUS_FDO_INTEFACE_PEER "org.freedesktop.DBus.Peer" /**< DBus Peer 
interface */
#define ELDBUS_ERROR_PENDING_CANCELED "org.enlightenment.DBus.Canceled" /**< 
Canceled error answer */
#define ELDBUS_ERROR_PENDING_TIMEOUT "org.freedesktop.DBus.Error.NoReply" /**< 
Timeout error answer */


-- 
Pierre Le Magourou


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to