jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=8e4dafcf286af5de7af01cb7f7be0d1b6a8980f7
commit 8e4dafcf286af5de7af01cb7f7be0d1b6a8980f7 Author: Jean-Philippe Andre <[email protected]> Date: Mon Oct 27 21:48:37 2014 +0900 Evas GL: Set umask before calling mkstemp Fixes Coverity issues: - CID 1039609 - CID 1039608 --- src/modules/evas/engines/gl_common/evas_gl_core.c | 8 ++++++++ src/modules/evas/engines/gl_common/evas_gl_shader.c | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/src/modules/evas/engines/gl_common/evas_gl_core.c b/src/modules/evas/engines/gl_common/evas_gl_core.c index ed2a089..78ae9e0 100644 --- a/src/modules/evas/engines/gl_common/evas_gl_core.c +++ b/src/modules/evas/engines/gl_common/evas_gl_core.c @@ -616,7 +616,15 @@ _surface_cap_cache_save() /* use mkstemp for writing */ snprintf(tmp_file, sizeof(tmp_file), "%s.XXXXXX", cap_file_path); + +#ifndef _WIN32 + mode_t old_umask = umask(S_IRWXG|S_IRWXO); +#endif tmpfd = mkstemp(tmp_file); +#ifndef _WIN32 + umask(old_umask); +#endif + if (tmpfd < 0) goto error; close(tmpfd); diff --git a/src/modules/evas/engines/gl_common/evas_gl_shader.c b/src/modules/evas/engines/gl_common/evas_gl_shader.c index 35201af..351415b 100644 --- a/src/modules/evas/engines/gl_common/evas_gl_shader.c +++ b/src/modules/evas/engines/gl_common/evas_gl_shader.c @@ -1167,7 +1167,15 @@ _evas_gl_common_shader_binary_save(Evas_GL_Shared *shared) /* use mkstemp for writing */ snprintf(tmp_file, sizeof(tmp_file), "%s.XXXXXX", bin_file_path); + +#ifndef _WIN32 + mode_t old_umask = umask(S_IRWXG|S_IRWXO); +#endif tmpfd = mkstemp(tmp_file); +#ifndef _WIN32 + umask(old_umask); +#endif + if (tmpfd < 0) goto error; close(tmpfd); --
