On 10/29/2014 09:10 AM, Tom Hacohen wrote: > On 29/10/14 13:03, kabeer khan wrote: >> devilhorns pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=5866e166bb02374930922e38cd1c89809a5520d4 >> >> commit 5866e166bb02374930922e38cd1c89809a5520d4 >> Author: kabeer khan <[email protected]> >> Date: Wed Oct 29 09:01:59 2014 -0400 >> >> Ecore File : Added test suite for Ecore File module >> >> Summary: >> Added 2 test cases. First to test initialise, shutdown Ecore_File >> module and second to test all file operation functions defined in the module. >> >> Signed-off-by: kabeer khan <[email protected]> >> >> Reviewers: devilhorns >> >> Subscribers: cedric >> >> Differential Revision: https://phab.enlightenment.org/D1600 >> --- > > Haven't looked at the quality/validity of the tests, but just having > test is such a huge improvement! Good job. > > One comment though, and Chris, please take care when reviewing: the > commit message doesn't follow the conventions (most notably, extra space > after "Ecore File" (before the colon), and too long lines in the commit > message itself. > > Thanks again for this test! > > -- > Tom.
Fair enough :) Yea, I should have read the commit message a little closer. You are right. This should have been shortened, and a summary added. I'll be a bit more deligent next time. Cheers, dh ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
