Hello Tom
Thank You for pointing out this issue. I will make sure to follow conventions for commit message. Cheers Kabeer ------- Original Message ------- Sender : Tom Hacohen<[email protected]> Senior Engineer/SRUK-Open Source/Samsung Electronics Date : Oct 29, 2014 18:40 (GMT+05:30) Title : Re: [E-devel] [EGIT] [core/efl] master 01/01: Ecore File : Added test suite for Ecore File module On 29/10/14 13:03, kabeer khan wrote: > devilhorns pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=5866e166bb02374930922e3 8cd1c89809a5520d4 > > commit 5866e166bb02374930922e38cd1c89809a5520d4 > Author: kabeer khan > Date: Wed Oct 29 09:01:59 2014 -0400 > > Ecore File : Added test suite for Ecore File module > > Summary: > Added 2 test cases. First to test initialise, shutdown Ecore_File module and second to test all file operation functions defined in the module. > > Signed-off-by: kabeer khan > > Reviewers: devilhorns > > Subscribers: cedric > > Differential Revision: https://phab.enlightenment.org/D1600 > --- Haven't looked at the quality/validity of the tests, but just having test is such a huge improvement! Good job. One comment though, and Chris, please take care when reviewing: the commit message doesn't follow the conventions (most notably, extra space after "Ecore File" (before the colon), and too long lines in the commit message itself. Thanks again for this test! -- Tom. ---------------------------------------------------------------------------- -- _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel [cid:[email protected]] [SeenTimeChecker?do=14f7afe1216e9674e497d5762129d7d51aa683d4ce8401bf53e47e2f 243a5ca9ddc79e3cd10304db25139e580ce36374e458eb91567068af8048f33cf1ed6b022630 67d8b8f027b11b20909a04efd4d2748cfe1d4e847419cf878f9a26ce15a0]
------------------------------------------------------------------------------
_______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
