2014-11-04 14:17 GMT+00:00 Tom Hacohen <tom.haco...@samsung.com>: > That's why autofoo has a variable for lib extension. Use it... >
I was thinking about doing that, but decided it was counter-intuitive. It'd actually be more code to use that variable as well as make editing things more painful (as I'd have to generate util.lua, which would have a need for util.lua.in, which editors wouldn't recognize as lua... I'm not even talking about that it's not only an extension thing, Windows uses foo.dll pattern while other OSes typically use libfoo.ext). We don't currently support any OSes that don't follow this pattern - and if we ever do, it'll be very easy to detect and port, as that code path is triggered when you build the EFL - as such, I'd opt for keeping the current code as it is, and only use the variable if ever necessary (which I don't think will happen). > > -- > Tom. > > On 04/11/14 11:58, Jean Guyomarc'h wrote: > > q66 pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=9fa0e6ea19a36f8fdf8e8fb6abb5c05cbf2bfc60 > > > > commit 9fa0e6ea19a36f8fdf8e8fb6abb5c05cbf2bfc60 > > Author: Jean Guyomarc'h <jean.guyoma...@gmail.com> > > Date: Tue Nov 4 11:55:14 2014 +0000 > > > > elua: load .dylib on OSX > > > > Summary: > > On OSX, libraries are generated as .dylib instead of .so. This led > elua to > > try loading missing libraries, and therefore crashing. > > > > @fix > > > > Reviewers: cedric, q66 > > > > Reviewed By: q66 > > > > Subscribers: cedric > > > > Differential Revision: https://phab.enlightenment.org/D1642 > > --- > > src/bin/elua/core/util.lua | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/src/bin/elua/core/util.lua b/src/bin/elua/core/util.lua > > index 78db3ab..44a5042 100644 > > --- a/src/bin/elua/core/util.lua > > +++ b/src/bin/elua/core/util.lua > > @@ -77,6 +77,8 @@ M.lib_load = function(libname) > > else > > if ffi.os == "Windows" then > > lib = ffi.load(ev .. "\\" .. libname .. ".dll") > > + elseif ffi.os == "OSX" then > > + lib = ffi.load(ev .. "/lib" .. libname .. ".dylib") > > else > > lib = ffi.load(ev .. "/lib" .. libname .. ".so") > > end > > > > > > > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > D5 ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
