jpeg pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=54afef04c2a8c285b4e8b010d59f22ef2cec14bb

commit 54afef04c2a8c285b4e8b010d59f22ef2cec14bb
Author: Jean-Philippe Andre <[email protected]>
Date:   Wed Nov 19 15:30:12 2014 +0900

    Evas GL: Change comment and DBG message
---
 src/modules/evas/engines/software_generic/evas_engine.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/modules/evas/engines/software_generic/evas_engine.c 
b/src/modules/evas/engines/software_generic/evas_engine.c
index ccb6ccb..f8e1504 100644
--- a/src/modules/evas/engines/software_generic/evas_engine.c
+++ b/src/modules/evas/engines/software_generic/evas_engine.c
@@ -3619,12 +3619,15 @@ gl_sym_init(void)
 #undef FINDSYM
 #undef FALLBAK
 
-   // Checking to see if this function exists is a poor but reasonable way to 
-   // check if it's gles but it works for now
-   // FIXME: This is wrong as OpenGL 4.1 also supports this function.
-   if (_sym_glGetShaderPrecisionFormat != 
(typeof(_sym_glGetShaderPrecisionFormat))sym_missing ) 
+   /*
+    * For desktop OpenGL we wrap these:
+    * - glGetShaderPrecisionFormat
+    * - glReleaseShaderCompiler
+    * - glShaderBinary
+    */
+   if (_sym_glGetShaderPrecisionFormat != 
(typeof(_sym_glGetShaderPrecisionFormat))sym_missing )
      {
-        DBG("GL Library is GLES.");
+        DBG("The GL library is OpenGL ES or OpenGL 4.1+");
         gl_lib_is_gles = 1;
      }
 
@@ -4051,6 +4054,7 @@ override_gl_apis(Evas_GL_API *api)
      {
         // Override functions wrapped by Evas_GL
         // GLES2.0 API compat on top of desktop gl
+        // Note that Open GL 4.1+ provides these 3 functions as well
         ORD(glGetShaderPrecisionFormat);
         ORD(glReleaseShaderCompiler);
         ORD(glShaderBinary);

-- 


Reply via email to