devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=b2b81f2cd49b65d9567e4bfe27fb173f8216d7bc
commit b2b81f2cd49b65d9567e4bfe27fb173f8216d7bc Author: Seunghun Lee <[email protected]> Date: Fri Nov 21 09:18:29 2014 -0500 ecore-drm: fix error check of _device_flags_set function Summary: the function return -1 if it's failed so checking for ! is incorrect. We should check if the return is less than zero. @fix Reviewers: gwanglim, devilhorns Reviewed By: devilhorns Subscribers: cedric Differential Revision: https://phab.enlightenment.org/D1682 --- src/lib/ecore_drm/ecore_drm_inputs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/ecore_drm/ecore_drm_inputs.c b/src/lib/ecore_drm/ecore_drm_inputs.c index 98ca426..9a1dcdf 100644 --- a/src/lib/ecore_drm/ecore_drm_inputs.c +++ b/src/lib/ecore_drm/ecore_drm_inputs.c @@ -97,7 +97,7 @@ _cb_device_opened(void *data, const Eldbus_Message *msg, Eldbus_Pending *pending goto cleanup; } - if (!(fd = _device_flags_set(fd))) + if ((fd = _device_flags_set(fd)) < 0) { ERR("\tCould not set fd flags"); goto release; --
