devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=6e46642dfb8124b34c8733deae4b8d029e362f09
commit 6e46642dfb8124b34c8733deae4b8d029e362f09 Author: Chris Michael <[email protected]> Date: Wed Dec 10 13:24:54 2014 -0500 eldbus: Fix possible null dereference reported by Coverity Summary: Fix Coverity CID1256952: reports a null derefence here due to eldbus_message_new returning NULL, thus causing a null dereference when trying to set reply->dbus_msg @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/eldbus/eldbus_message.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/eldbus/eldbus_message.c b/src/lib/eldbus/eldbus_message.c index d6b18d3..03b8d64 100644 --- a/src/lib/eldbus/eldbus_message.c +++ b/src/lib/eldbus/eldbus_message.c @@ -835,6 +835,8 @@ eldbus_message_error_new(const Eldbus_Message *msg, const char *error_name, cons EINA_SAFETY_ON_NULL_RETURN_VAL(error_msg, NULL); reply = eldbus_message_new(EINA_FALSE); + EINA_SAFETY_ON_NULL_RETURN_VAL(reply, NULL); + reply->dbus_msg = dbus_message_new_error(msg->dbus_msg, error_name, error_msg); --
