Hi, On Thu, Dec 11, 2014 at 9:04 PM, Simon <[email protected]> wrote:
> I presume this is breaking my enlightenment build atm, > > https://build.opensuse.org/package/live_build_log/X11:Enlightenment:Nightly/enlightenment/openSUSE_13.2/x86_64 > > efl, elementary and enlightenment were all built from tars created with > make dist > Right... looks like I should have been a bit more careful here :) Thanks Chris for the quick revert. I guess if we want to be able to break API/ABI of those structs in the future, this will need versioning or something like that. Tricky since the header is a magic number generated by rand(). Fyi the reason I want to break ABI is loosely related to T1437 (I wanted to add gl information to the struct). > > > Cheers > Simon > > On 12/11/2014 04:05 PM, Jean-Philippe ANDRÉ wrote: > > jpeg pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=df3958bb892b313ab91b9f0bd5a84452bb62388c > > > > commit df3958bb892b313ab91b9f0bd5a84452bb62388c > > Author: Jean-Philippe Andre <[email protected]> > > Date: Wed Dec 10 20:26:55 2014 +0900 > > > > Evas: Stop installing Evas_Engine_Stuff.h > > > > Those really are internals shared between ecore and evas. > > Considering ecore & evas are just part of EFL, and expedite > > now doesn't even rely on these headers anymore, we can safely > > remove them from the dist packages. > > > > This will allow us to break this seemingly internal API/ABI. > > --- > > src/Makefile_Evas.am | 28 +++++++++++++++------------- > > 1 file changed, 15 insertions(+), 13 deletions(-) > > > > diff --git a/src/Makefile_Evas.am b/src/Makefile_Evas.am > > index a625ec6..1badc41 100644 > > --- a/src/Makefile_Evas.am > > +++ b/src/Makefile_Evas.am > > @@ -505,8 +505,10 @@ > modules_evas_engines_software_generic_module_la_LDFLAGS = -module > @EFL_LTMODULE_ > > modules_evas_engines_software_generic_module_la_LIBTOOLFLAGS = > --tag=disable-static > > endif > > > > +dist_noinst_DATA = > > + > > if BUILD_ENGINE_BUFFER > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/buffer/Evas_Engine_Buffer.h > > +dist_noinst_DATA += modules/evas/engines/buffer/Evas_Engine_Buffer.h > > BUFFER_SOURCES = \ > > modules/evas/engines/buffer/evas_engine.c \ > > modules/evas/engines/buffer/evas_outbuf.c \ > > @@ -529,7 +531,7 @@ endif > > endif > > > > if BUILD_ENGINE_FB > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/fb/Evas_Engine_FB.h > > +dist_noinst_DATA += modules/evas/engines/fb/Evas_Engine_FB.h > > FB_SOURCES = \ > > modules/evas/engines/fb/evas_engine.c \ > > modules/evas/engines/fb/evas_fb_main.c \ > > @@ -740,7 +742,7 @@ endif > > endif > > > > if BUILD_ENGINE_GL_COCOA > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/gl_cocoa/Evas_Engine_GL_Cocoa.h > > +dist_noinst_DATA += modules/evas/engines/gl_cocoa/Evas_Engine_GL_Cocoa.h > > GL_COCOA_SOURCES = \ > > modules/evas/engines/gl_cocoa/evas_engine.c \ > > modules/evas/engines/gl_cocoa/evas_gl_cocoa_main.m \ > > @@ -778,7 +780,7 @@ endif > > endif > > > > if BUILD_ENGINE_GL_SDL > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/gl_sdl/Evas_Engine_GL_SDL.h > > +dist_noinst_DATA += modules/evas/engines/gl_sdl/Evas_Engine_GL_SDL.h > > GL_SDL_SOURCES = \ > > modules/evas/engines/gl_sdl/evas_engine.c \ > > modules/evas/engines/gl_sdl/evas_engine.h > > @@ -809,7 +811,7 @@ endif > > endif > > > > if BUILD_ENGINE_GL_X11 > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/gl_x11/Evas_Engine_GL_X11.h > > +dist_noinst_DATA += modules/evas/engines/gl_x11/Evas_Engine_GL_X11.h > > GL_X11_SOURCES = \ > > modules/evas/engines/gl_x11/evas_engine.c \ > > modules/evas/engines/gl_x11/evas_x_main.c \ > > @@ -842,7 +844,7 @@ endif > > endif > > > > if BUILD_ENGINE_PSL1GHT > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/psl1ght/Evas_Engine_PSL1GHT.h > > +dist_noinst_DATA += modules/evas/engines/psl1ght/Evas_Engine_PSL1GHT.h > > PSL1GHT_SOURCES = \ > > modules/evas/engines/psl1ght/evas_engine.c \ > > modules/evas/engines/psl1ght/rsxutil.c \ > > @@ -871,7 +873,7 @@ endif > > endif > > > > if BUILD_ENGINE_SOFTWARE_DDRAW > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/software_ddraw/Evas_Engine_Software_DDraw.h > > +dist_noinst_DATA += > modules/evas/engines/software_ddraw/Evas_Engine_Software_DDraw.h > > SOFTWARE_DDRAW_SOURCES = \ > > modules/evas/engines/software_ddraw/evas_engine.c \ > > modules/evas/engines/software_ddraw/evas_outbuf.c \ > > @@ -903,7 +905,7 @@ endif > > endif > > > > if BUILD_ENGINE_SOFTWARE_GDI > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/software_gdi/Evas_Engine_Software_Gdi.h > > +dist_noinst_DATA += > modules/evas/engines/software_gdi/Evas_Engine_Software_Gdi.h > > SOFTWARE_GDI_SOURCES = \ > > modules/evas/engines/software_gdi/evas_engine.c \ > > modules/evas/engines/software_gdi/evas_outbuf.c \ > > @@ -933,7 +935,7 @@ endif > > endif > > > > if BUILD_ENGINE_SOFTWARE_X11 > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/software_x11/Evas_Engine_Software_X11.h > > +dist_noinst_DATA += > modules/evas/engines/software_x11/Evas_Engine_Software_X11.h > > SOFTWARE_X11_SOURCES = \ > > modules/evas/engines/software_x11/evas_engine.c \ > > modules/evas/engines/software_x11/evas_engine.h \ > > @@ -991,7 +993,7 @@ endif > > endif > > > > if BUILD_ENGINE_WAYLAND_EGL > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/wayland_egl/Evas_Engine_Wayland_Egl.h > > +dist_noinst_DATA += > modules/evas/engines/wayland_egl/Evas_Engine_Wayland_Egl.h > > WAYLAND_EGL_SOURCES = \ > > modules/evas/engines/wayland_egl/evas_engine.c \ > > modules/evas/engines/wayland_egl/evas_wl_main.c \ > > @@ -1020,7 +1022,7 @@ endif > > endif > > > > if BUILD_ENGINE_WAYLAND_SHM > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h > > +dist_noinst_DATA += > modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h > > WAYLAND_SHM_SOURCES = \ > > modules/evas/engines/wayland_shm/Evas_Engine_Wayland_Shm.h \ > > modules/evas/engines/wayland_shm/evas_engine.c \ > > @@ -1052,7 +1054,7 @@ endif > > endif > > > > if BUILD_ENGINE_DRM > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/drm/Evas_Engine_Drm.h > > +dist_noinst_DATA += modules/evas/engines/drm/Evas_Engine_Drm.h > > DRM_SOURCES = \ > > modules/evas/engines/drm/evas_drm.c \ > > modules/evas/engines/drm/evas_bufmgr.c \ > > @@ -1087,7 +1089,7 @@ endif > > endif > > > > if BUILD_ENGINE_GL_DRM > > -dist_installed_evasmainheaders_DATA += > modules/evas/engines/gl_drm/Evas_Engine_GL_Drm.h > > +dist_noinst_DATA += modules/evas/engines/gl_drm/Evas_Engine_GL_Drm.h > > GL_DRM_SOURCES = \ > > modules/evas/engines/gl_drm/evas_drm.c \ > > modules/evas/engines/gl_drm/evas_drm_main.c \ > > > > > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > > http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Jean-Philippe André ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
