On Wed, Dec 31, 2014 at 12:21 AM, Tom Hacohen <[email protected]> wrote:
> On 30/12/14 15:15, Daniel Juyung Seo wrote: > > seoz pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/elementary.git/commit/?id=d389a44b42d482414d1bfb2f4d0ccebbda510d7b > > > > commit d389a44b42d482414d1bfb2f4d0ccebbda510d7b > > Author: Daniel Juyung Seo <[email protected]> > > Date: Wed Dec 31 00:12:57 2014 +0900 > > > > gesture_layer: Remove unnecessary value assignment. > > > > This fixes coverity CID 1261280. > > But this is not critical. > > --- > > src/lib/elm_gesture_layer.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/src/lib/elm_gesture_layer.c b/src/lib/elm_gesture_layer.c > > index fe2ec64..68630ba 100644 > > --- a/src/lib/elm_gesture_layer.c > > +++ b/src/lib/elm_gesture_layer.c > > @@ -1900,8 +1900,8 @@ _tap_gesture_test(Evas_Object *obj, > > } > > else if (eina_list_count(pe_list) > st->n_taps_needed) > > { /* If we arleady got too many touches for this gesture. > */ > > - ev_flag = _state_set(gesture, ELM_GESTURE_STATE_ABORT, > > - &st->info, EINA_FALSE); > > + _state_set(gesture, ELM_GESTURE_STATE_ABORT, > > + &st->info, EINA_FALSE); > > } > > > > if (gesture->state == ELM_GESTURE_STATE_MOVE) > > @@ -1925,8 +1925,8 @@ _tap_gesture_test(Evas_Object *obj, > > > > if (move && (n > 0)) > > { > > - ev_flag = _state_set(gesture, ELM_GESTURE_STATE_MOVE, > > - &st->info, EINA_TRUE); > > + _state_set(gesture, ELM_GESTURE_STATE_MOVE, > > + &st->info, EINA_TRUE); > > } > > } > > > > @@ -1977,8 +1977,8 @@ _tap_gesture_test(Evas_Object *obj, > > /* We don't report MOVE when (n >= > st->n_taps_needed) > > because will be END or ABORT at this stage */ > > st->info.n = eina_list_count(st->l); > > - ev_flag = _state_set(gesture, ELM_GESTURE_STATE_MOVE, > > - &st->info, EINA_TRUE); > > + _state_set(gesture, ELM_GESTURE_STATE_MOVE, > > + &st->info, EINA_TRUE); > > } > > } > > > > > > This smells wrong... I think this value should actually be used, no? > > It's used for preventing events from propagating, or at least should... > > > Hmm maybe you're right. Need to read the code more. If you find a proper way to use it, please add them in. As this removal does not change anything we can add them back when we find a good solution. Thanks for the feedback. Daniel Juyung Seo (SeoZ) > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming! The Go Parallel Website, > sponsored by Intel and developed in partnership with Slashdot Media, is > your > hub for all things parallel software development, from weekly thought > leadership blogs to news, videos, case studies, tutorials and more. Take a > look and join the conversation now. http://goparallel.sourceforge.net > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
