hmm, this one seems quite wrong to me. Is there a use case for this situation? why the swallow should fail? or you are just hiding a bug? Hiding an evas obj to hide a bug is really the wrong way to go
Thanks 2015-01-02 4:11 GMT+01:00 ChunEon Park <[email protected]>: > hermet pushed a commit to branch master. > > > http://git.enlightenment.org/core/elementary.git/commit/?id=0da29a39e8b1f2d080ba12fcd94398b3aacb4a18 > > commit 0da29a39e8b1f2d080ba12fcd94398b3aacb4a18 > Author: ChunEon Park <[email protected]> > Date: Fri Jan 2 12:14:41 2015 +0900 > > genlist: exceptional handling. > > just be hidden if contents are failed to swallow. > --- > src/lib/elm_genlist.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c > index 83eef29..ff91d2d 100644 > --- a/src/lib/elm_genlist.c > +++ b/src/lib/elm_genlist.c > @@ -363,8 +363,13 @@ _item_content_realize(Elm_Gen_Item *it, > if (ic) > { > res = eina_list_append(res, ic); > - edje_object_part_swallow(target, key, ic); > - evas_object_show(ic); > + if (!edje_object_part_swallow(target, key, ic)) > + { > + ERR("%s (%p) can not be swallowed into %s", > + evas_object_type_get(ic), ic, key); > + evas_object_hide(ic); > + continue; > + } > elm_widget_sub_object_add(WIDGET(it), ic); > if (eo_do(EO_OBJ(it), elm_wdg_item_disabled_get())) > elm_widget_disabled_set(ic, EINA_TRUE); > > -- > > > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
