Yo Miki,

Run elm_test->check (not related to check but to icons so a lot may fall
on it). You will see a lot of bloody Eo errors. If you revert your
patch, you won't see these errors anymore.

Tom, please confirm. Edje_Object and Elm_Widget are regular objects, and
Eo forbids inheritance from more than one regular class. Meaning you
can't do that.

I even don't think that from Elm side, it is right to have this kind of
inheritance.

D2

On 01/06/15 22:15, Mike Blumenkrantz wrote:
> discomfitor pushed a commit to branch master.
>
> http://git.enlightenment.org/core/elementary.git/commit/?id=37b6f6da356000824ddfdad69b785dc04addbde4
>
> commit 37b6f6da356000824ddfdad69b785dc04addbde4
> Author: Mike Blumenkrantz <zm...@osg.samsung.com>
> Date:   Tue Jan 6 15:19:00 2015 -0500
>
>     elm_image now inherits edje signal emit
>     
>     @feature
> ---
>  src/lib/elm_image.c  | 7 +++++++
>  src/lib/elm_image.eo | 2 ++
>  2 files changed, 9 insertions(+)
>
> diff --git a/src/lib/elm_image.c b/src/lib/elm_image.c
> index a3eb116..2ba7b2d 100644
> --- a/src/lib/elm_image.c
> +++ b/src/lib/elm_image.c
> @@ -915,6 +915,13 @@ _elm_image_efl_file_file_set(Eo *obj, Elm_Image_Data 
> *sd, const char *file, cons
>     return ret;
>  }
>  
> +EOLIAN static void
> +_elm_image_edje_object_signal_emit(Eo *obj EINA_UNUSED, Elm_Image_Data *sd, 
> const char *emission, const char *source)
> +{
> +   if (sd->edje)
> +     edje_object_signal_emit(sd->img, emission, source);
> +}
> +
>  EOLIAN static Eina_Bool
>  _elm_image_mmap_set(Eo *obj, Elm_Image_Data *sd, const Eina_File *f, const 
> char *key)
>  {
> diff --git a/src/lib/elm_image.eo b/src/lib/elm_image.eo
> index dc77b55..ef934d4 100644
> --- a/src/lib/elm_image.eo
> +++ b/src/lib/elm_image.eo
> @@ -1,4 +1,5 @@
>  class Elm_Image (Elm_Widget, Efl.File, Efl.Image, Evas.Clickable_Interface,
> +                 Edje.Object,
>                   Elm_Interface_Atspi_Image, 
> Elm_Interface_Atspi_Widget_Action)
>  {
>     eo_prefix: elm_obj_image;
> @@ -541,6 +542,7 @@ class Elm_Image (Elm_Widget, Efl.File, Efl.Image, 
> Evas.Clickable_Interface,
>        Efl.Image.load_size.get;
>        Efl.Image.smooth_scale.set;
>        Efl.Image.smooth_scale.get;
> +      Edje.Object.signal_emit;
>        Evas.Object_Smart.hide;
>        Evas.Object_Smart.clip.set;
>        Evas.Object_Smart.clip_unset;
>


------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to