Hello my dear, On 01/21/15 21:15, Tom Hacohen wrote: > On 21/01/15 18:45, Daniel Zaoui wrote: >> jackdanielz pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=87d523478b3c3f37bd82548b5f3c822b1501c404 >> >> commit 87d523478b3c3f37bd82548b5f3c822b1501c404 >> Author: Daniel Zaoui <daniel.za...@yahoo.com> >> Date: Wed Jan 21 20:42:58 2015 +0200 >> >> warning-- >> --- >> src/lib/evas/common/evas_scale_sample.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/lib/evas/common/evas_scale_sample.c >> b/src/lib/evas/common/evas_scale_sample.c >> index 91a75eb..5536115 100644 >> --- a/src/lib/evas/common/evas_scale_sample.c >> +++ b/src/lib/evas/common/evas_scale_sample.c >> @@ -334,7 +334,7 @@ scale_rgba_in_to_out_clip_sample_internal(RGBA_Image >> *src, RGBA_Image *dst, >> { >> int x, y; >> int *lin_ptr; >> - DATA32 *buf, *dptr; >> + DATA32 *buf = NULL, *dptr; >> DATA32 **row_ptr; >> DATA32 *ptr, *dst_ptr, *src_data, *dst_data; >> DATA8 *mask; >> > 1. Commit message.
I didn't think the commit message was so important for this kind of patch. > 2. As I've said many times before, silencing warnings is > counter-productive. We turn warnings on in order to spot potential > errors. By silencing the warning in a piece of code you don't know, you > are hiding potential issues. In case I'm wrong and you actually do know > this code and have investigated this issue properly, write something in > the commit message! I looked at the code. Imo, the code is right (weird but right) and the problem is that gcc didn't note that the allocation of buf and its use depend on a same condition (mul.use). Maybe I am wrong but yes, I checked the code and tried to understand. Anyway, I don't hate you for that. Daniel > > -- > Tom. > > > ------------------------------------------------------------------------------ > New Year. New Location. New Benefits. New Data Center in Ashburn, VA. > GigeNET is offering a free month of service with a new server in Ashburn. > Choose from 2 high performing configs, both with 100TB of bandwidth. > Higher redundancy.Lower latency.Increased capacity.Completely compliant. > http://p.sf.net/sfu/gigenet > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ New Year. New Location. New Benefits. New Data Center in Ashburn, VA. GigeNET is offering a free month of service with a new server in Ashburn. Choose from 2 high performing configs, both with 100TB of bandwidth. Higher redundancy.Lower latency.Increased capacity.Completely compliant. http://p.sf.net/sfu/gigenet _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
