On Mon, Feb 2, 2015 at 1:51 PM, Daniel Hirt <[email protected]> wrote: > herdsman pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=7cbf22212f0c3292dbd1919f4cdd15802e9b9d84 > > commit 7cbf22212f0c3292dbd1919f4cdd15802e9b9d84 > Author: Daniel Hirt <[email protected]> > Date: Mon Feb 2 14:10:04 2015 +0200 > > Revert "eina: eina_file - fix "invalid read of size 1" in valgrind" > > This reverts commit f52f5628916f44a6b8ce1fdd3b9cc40f6c997eda. > > This is reverted because it breaks eina_file_path_sanitize when using > "/../" in paths, for example: > eina_file_path_sanitize("/home/../mydir/myfile") > returns: "/mydir/myfili" > > What invalid read size does this fix? Why was no test case specified? > Anyway, this change affects too much code to leave it in like this.
Hum. You can see the problem easily if you do run any of the edje_cc in our tree under valgrind. The problem vanish with this patch and it does still compile correctly after the patch, but I guess that just wasn't a good enough test. If you have time to investigate more, I don't. -- Cedric BAIL ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
