On Tue, 03 Feb 2015 16:28:22 +0100 Stefan Schmidt <[email protected]> said:
> Hello. > > On 27/01/15 16:04, Stefan Schmidt wrote: > > Hello. > > > > On 25/11/14 04:43, Jason Gerecke wrote: > >> raster pushed a commit to branch master. > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=26c943bac0d4b62bce63a6b575c58d15e5e6113f > >> > >> commit 26c943bac0d4b62bce63a6b575c58d15e5e6113f > >> Author: Jason Gerecke <[email protected]> > >> Date: Tue Nov 25 12:07:50 2014 +0900 > >> > >> Expose device (e.g. pen) axis information to applications > >> > >> > > [snap] > >> > >> diff --git a/src/lib/ecore_x/Ecore_X.h b/src/lib/ecore_x/Ecore_X.h > >> index 7272b6a..d03003b 100644 > >> --- a/src/lib/ecore_x/Ecore_X.h > >> +++ b/src/lib/ecore_x/Ecore_X.h > >> @@ -2529,7 +2529,7 @@ EAPI Eina_Bool ecore_x_image_is_argb32_get > >> (Ecore_X_Image *im); > >> EAPI Eina_Bool ecore_x_image_to_argb_convert(void *src, int sbpp, > >> int sbpl, Ecore_X_Colormap c, Ecore_X_Visual v, int x, int y, int w, int > >> h, unsigned int *dst, int dbpl, int dx, int dy); -EAPI Eina_Bool > >> ecore_x_input_multi_select(Ecore_X_Window win); +EAPI Eina_Bool > >> ecore_x_input_select(Ecore_X_Window win); EAPI Eina_Bool > >> ecore_x_input_raw_select(Ecore_X_Window win); /**< @since 1.8 */ > >> > > This removed a released API. Was this on purpose? > > > > While this can break library users this actually also break our own > > ecore_xcb code which still uses ecore_x_input_multi_select(). > > Ping? > > My current understanding is that this is an API break we introduced and > did not catch before. Before I revert I want to hear about this. Raster > did you just missed this during review? fixed. i missed it in review. i was looking at the meat of the changes - i missed the api (no good reason to change the name) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
