[EGIT] [core/efl] master 02/17: eina: memcmp can't be used to compare timeval due to potential padding on 64bit architecture.

[pierre lamot]

cedric pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=019b9e55c96705aa9d15d186e3f8a8c5966e4e73

commit 019b9e55c96705aa9d15d186e3f8a8c5966e4e73
Author: pierre lamot <pierre.la...@openwide.fr>
Date:   Thu Dec 11 11:21:50 2014 +0100

    eina: memcmp can't be used to compare timeval due to potential padding on 
64bit architecture.
    
    Signed-off-by: Cedric BAIL <ced...@osg.samsung.com>
---
 src/tests/eina/eina_test_value.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/tests/eina/eina_test_value.c b/src/tests/eina/eina_test_value.c
index 1c80404..454aa60 100644
--- a/src/tests/eina/eina_test_value.c
+++ b/src/tests/eina/eina_test_value.c
@@ -2314,7 +2314,8 @@ START_TEST(eina_value_test_timeval)
    itv.tv_usec = 123;
    fail_unless(eina_value_set(value, itv));
    fail_unless(eina_value_get(value, &otv));
-   fail_unless(memcmp(&itv, &otv, sizeof(struct timeval)) == 0);
+   fail_unless(itv.tv_sec == otv.tv_sec);
+   fail_unless(itv.tv_usec == otv.tv_usec);
 
    itv.tv_sec = 3;
    itv.tv_usec = -1;
@@ -2322,7 +2323,8 @@ START_TEST(eina_value_test_timeval)
    fail_unless(eina_value_get(value, &otv));
    itv.tv_sec = 2;
    itv.tv_usec = 999999;
-   fail_unless(memcmp(&itv, &otv, sizeof(struct timeval)) == 0);
+   fail_unless(itv.tv_sec == otv.tv_sec);
+   fail_unless(itv.tv_usec == otv.tv_usec);
 
    fail_unless(eina_value_setup(&other, EINA_VALUE_TYPE_CHAR));
    fail_unless(eina_value_convert(value, &other));

--