seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=d887cd1113e846d88b5b5a648397db5f21e01668
commit d887cd1113e846d88b5b5a648397db5f21e01668 Author: woochan lee <[email protected]> Date: Sat Feb 14 22:56:05 2015 +0900 multibuttonentry: Item selected callback called twice redundantly. Summary: _current_item_change() called at _item_select() internally. it means _current_item_changed() called two times in vain. so that's why item select callback called two times. @fix Test Plan: 1. Run elementary_test 2. Excute multibuttonentry sample. 3. Added some items and click the item area. 4. Select signal called two times. Reviewers: Hermet, woohyun, JackDanielZ, seoz Reviewed By: seoz Differential Revision: https://phab.enlightenment.org/D1955 --- src/lib/elc_multibuttonentry.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/lib/elc_multibuttonentry.c b/src/lib/elc_multibuttonentry.c index d68dcee..51491db 100644 --- a/src/lib/elc_multibuttonentry.c +++ b/src/lib/elc_multibuttonentry.c @@ -481,16 +481,10 @@ _on_item_clicked(void *data, if (sd->view_state == MULTIBUTTONENTRY_VIEW_SHRINK) return; - _current_item_change(WIDGET(it), eo_it); + _item_select(WIDGET(it), it); if (sd->selected_it) - { - if ((it = sd->selected_it) != NULL) - { - evas_object_smart_callback_call(VIEW(it), SIG_ITEM_CLICKED, eo_it); - _item_select(WIDGET(it), it); - } - } + evas_object_smart_callback_call(VIEW(it), SIG_ITEM_CLICKED, eo_it); } static void --
