On 04/03/15 16:55, Christopher Michael wrote: > Commit guidelines. > > Tom, when you review commits, make sure they conform to our commit > guidelines. In this case, the summary line. This is not a single > instance, I've seen others too.
Huh? This is exactness, it's not covered by our commit guidelines, only the EFL/Elementary/Enlightenment are. Anyhow, there's nothing wrong with this summary line, except for maybe the lower case letter at the beginning of the line. > > On 03/04/2015 10:07 AM, kabeer khan wrote: >> tasn pushed a commit to branch master. >> >> http://git.enlightenment.org/tools/exactness.git/commit/?id=079dbb6dd542fc0066026cbf82ebe6db347d5867 >> >> commit 079dbb6dd542fc0066026cbf82ebe6db347d5867 >> Author: kabeer khan <[email protected]> >> Date: Wed Mar 4 15:00:05 2015 +0000 >> >> added code to enable shots capturing of ecore_evas and evas examples >> >> Summary: Signed-off-by: kabeer khan <[email protected]> >> >> Reviewers: cedric, tasn >> >> Reviewed By: tasn >> >> Differential Revision: https://phab.enlightenment.org/D2082 >> --- >> src/lib/tsuite_evas_hook.c | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/src/lib/tsuite_evas_hook.c b/src/lib/tsuite_evas_hook.c >> index 03ca995..d229a05 100644 >> --- a/src/lib/tsuite_evas_hook.c >> +++ b/src/lib/tsuite_evas_hook.c >> @@ -331,6 +331,21 @@ evas_new(void) >> return evas; >> } >> >> +EAPI Ecore_Evas * >> +ecore_evas_new(const char *engine_name, int x, int y, >> + int w, int h, const char *extra_options) >> +{ >> + Ecore_Evas *ecore_evas; >> + Ecore_Evas * (*_ecore_evas_new)(const char *engine_name, int x, int y, >> + int w, int h, const char *extra_options) = dlsym(RTLD_NEXT, >> __FUNCTION__); >> + >> + if(!_hook_setting->recording) >> + ecore_evas = _ecore_evas_new("buffer", x, y, w, h, extra_options); >> + else >> + ecore_evas = _ecore_evas_new(engine_name, x, y, w, h, extra_options); >> + return ecore_evas; >> +} >> + >> static Eina_Bool >> tsuite_feed_event(void *data) >> { >> > > > ------------------------------------------------------------------------------ > Dive into the World of Parallel Programming The Go Parallel Website, sponsored > by Intel and developed in partnership with Slashdot Media, is your hub for all > things parallel software development, from weekly thought leadership blogs to > news, videos, case studies, tutorials and more. Take a look and join the > conversation now. http://goparallel.sourceforge.net/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
