hermet pushed a commit to branch elementary-1.13.
http://git.enlightenment.org/core/elementary.git/commit/?id=5db6182a7c879013f33a773830e45b06336781a2
commit 5db6182a7c879013f33a773830e45b06336781a2
Author: woochan lee <wc0917....@samsung.com>
Date: Thu Mar 12 15:42:30 2015 +0900
genlist: Send param item type instead of eo item type.
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with
parameter.
It makes crash when access it->item. it is eo item type actually so it
doesn't have member as item or something.
@fix
Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2136
---
src/lib/elm_genlist.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c
index 299cbec..f7ce044 100644
--- a/src/lib/elm_genlist.c
+++ b/src/lib/elm_genlist.c
@@ -7493,9 +7493,12 @@ _elm_genlist_select_mode_set(Eo *obj EINA_UNUSED,
Elm_Genlist_Data *sd, Elm_Obje
(sd->select_mode == ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY))
{
Eina_List *l, *ll;
- Elm_Gen_Item *it;
- EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, it)
+ Elm_Object_Item *eo_it;
+ EINA_LIST_FOREACH_SAFE(sd->selected, l, ll, eo_it)
+ {
+ ELM_GENLIST_ITEM_DATA_GET(eo_it, it);
_item_unselect(it);
+ }
}
}
--
