On Mon, Apr 20, 2015 at 5:16 PM, Christopher Michael < [email protected]> wrote:
> On 04/20/2015 12:10 PM, Daniel Kolesa wrote: > > On Mon, Apr 20, 2015 at 4:49 PM, Christopher Michael < > [email protected] > >> wrote: > > > >> devilhorns pushed a commit to branch master. > >> > >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=d625167e0707cca3648e9933ef65936043372447 > >> > >> commit d625167e0707cca3648e9933ef65936043372447 > >> Author: Chris Michael <[email protected]> > >> Date: Mon Apr 20 11:47:55 2015 -0400 > >> > >> ecore-drm: Remove 'defined but not used' function > >> > >> Summary: As we no longer require the idler to repaint outputs, > comment > >> out the function that was defined for the idler. > >> > >> NB: I left it commented (and not totally removed) just in case it > is > >> needed for a later (undiscovered) issue > >> > >> @fix > >> > >> Signed-off-by: Chris Michael <[email protected]> > >> --- > >> src/lib/ecore_drm/ecore_drm_device.c | 40 > >> ++++++++++++++++++------------------ > >> 1 file changed, 20 insertions(+), 20 deletions(-) > >> > >> diff --git a/src/lib/ecore_drm/ecore_drm_device.c > >> b/src/lib/ecore_drm/ecore_drm_device.c > >> index e6a5c00..abc3e5a 100644 > >> --- a/src/lib/ecore_drm/ecore_drm_device.c > >> +++ b/src/lib/ecore_drm/ecore_drm_device.c > >> @@ -86,26 +86,26 @@ _ecore_drm_device_cb_event(void *data, > >> Ecore_Fd_Handler *hdlr EINA_UNUSED) > >> return ECORE_CALLBACK_RENEW; > >> } > >> > >> -static Eina_Bool > >> -_ecore_drm_device_cb_idle(void *data) > >> -{ > >> - Ecore_Drm_Device *dev; > >> - Ecore_Drm_Output *output; > >> - Eina_List *l; > >> - > >> - if (!(dev = data)) return ECORE_CALLBACK_CANCEL; > >> - > >> - if (!dev->active) return ECORE_CALLBACK_RENEW; > >> - > >> - EINA_LIST_FOREACH(dev->outputs, l, output) > >> - { > >> - if ((!output->enabled) || (!output->need_repaint)) continue; > >> - if (output->repaint_scheduled) continue; > >> - _ecore_drm_output_repaint_start(output); > >> - } > >> - > >> - return ECORE_CALLBACK_RENEW; > >> -} > >> +/* static Eina_Bool */ > >> +/* _ecore_drm_device_cb_idle(void *data) */ > >> +/* { */ > >> +/* Ecore_Drm_Device *dev; */ > >> +/* Ecore_Drm_Output *output; */ > >> +/* Eina_List *l; */ > >> + > >> +/* if (!(dev = data)) return ECORE_CALLBACK_CANCEL; */ > >> + > >> +/* if (!dev->active) return ECORE_CALLBACK_RENEW; */ > >> + > >> +/* EINA_LIST_FOREACH(dev->outputs, l, output) */ > >> +/* { */ > >> +/* if ((!output->enabled) || (!output->need_repaint)) > continue; */ > >> +/* if (output->repaint_scheduled) continue; */ > >> +/* _ecore_drm_output_repaint_start(output); */ > >> +/* } */ > >> + > >> +/* return ECORE_CALLBACK_RENEW; */ > >> +/* } */ > >> > > > > Dude, ever heard of #if 0...#endif? This is fugly, generates a bad diff, > > etc. > > > > Fixed. > Cool, thanks. :) > > > > >> > >> static void > >> _ecore_drm_device_cb_output_event(const char *device EINA_UNUSED, > >> Eeze_Udev_Event event EINA_UNUSED, void *data, Eeze_Udev_Watch *watch > >> EINA_UNUSED) > >> > >> -- > >> > >> > >> > > D5 > > > > ------------------------------------------------------------------------------ > BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT > Develop your own process in accordance with the BPMN 2 standard > Learn Process modeling best practices with Bonita BPM through live > exercises > http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- > event?utm_ > source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
