On 15/05/15 11:51, ChunEon Park wrote: > I agree on you. > Current vector is not fully stable. > And I don't want crashes in vector usage. > > Subhransu knows the problem and keeping look the issue. > Once it's fixed, he will remove it. >
If I had a lego piece for every time I've heard that, I would have built myself a lego deathstar already. -- Tom. > ------------------------------------ > -Regards, Hermet- > > -----Original Message----- > From: "Tom Hacohen"<t...@osg.samsung.com> > To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2015-05-08 (금) 20:44:30 > Subject: Re: [E-devel] [EGIT] [core/efl] master 02/02: evas/canvas: Null > check for base class data pointer. > > This is pretty much not the way to go. We don't want to hide issues, we > want to fix them. You just fixed a very small symptom. I don't see a > ticket on phab, I don't see a report, I don't see anything. This is bad. > > -- > Tom. > > On 08/05/15 12:40, Subhransu Mohanty wrote: >> hermet pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=8f55ac7550360e6afcdc0567685ceb25b7ecec63 >> >> commit 8f55ac7550360e6afcdc0567685ceb25b7ecec63 >> Author: Subhransu Mohanty <sub.moha...@samsung.com> >> Date: Fri May 8 20:32:40 2015 +0900 >> >> evas/canvas: Null check for base class data pointer. >> --- >> src/lib/evas/canvas/evas_object_vg.c 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/lib/evas/canvas/evas_object_vg.c >> b/src/lib/evas/canvas/evas_object_vg.c >> index 57d4090..cca772a 100644 >> --- a/src/lib/evas/canvas/evas_object_vg.c >> +++ b/src/lib/evas/canvas/evas_object_vg.c >> @@ -226,6 +226,10 @@ evas_object_vg_render_pre(Evas_Object *eo_obj, >> // FIXME: for now the walking Evas_VG_Node tree doesn't trigger any >> damage >> // So just forcing it here if necessary >> rnd = eo_data_scope_get(vd->root, EFL_VG_BASE_CLASS); >> + >> + //FIXME find the reason for NULL Base Class in some case? >> + if (!rnd) return; >> + >> if (rnd->changed) >> { >> rnd->changed = EINA_FALSE; >> > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
