I see. It will be better to revert if this breaks the compatibility. Thanks.
------------------------------------ -Regards, Hermet- -----Original Message----- From: "Davide Andreoli"<d...@gurumeditation.it> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: <g...@lists.enlightenment.org>; Sent: 2015-05-29 (금) 03:27:02 Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: Spinner: Add changed callback call when spinner value set. Are you sure we really want this behavior? I found this kind of callback (fired by the use of the API) quite annoying most of the time... for example: you have a photo app with a visible spinner for the image zoom level, when the user "move" the spinner you change the zoom of the image. But the zoom level can also be changed in other way (mouse wheel or other buttons), so when the zoom change you set the spinner to the new value... this now trigger a changed callback as the spinner where changed by the user, causing your app to go in a loop. Another example: you have 2 spinner "linked" together (for example width and height of an image), when the user move the first spinner the code change the value of the second spinner, now this cause the callback to be called on the second... that change the value of the first... and so on, in an infinite loop. And, as always, I found this kind of behavior changes not acceptable in a released lib, as can break the functionality of existing app. I suggest everyone that are using Spinner in their apps to recheck the functionality of their widgets. 2015-05-28 13:42 GMT+02:00 woochan lee <wc0917....@samsung.com>: > hermet pushed a commit to branch master. > > > http://git.enlightenment.org/core/elementary.git/commit/?id=8278dff6a742c391f7c04c3de1033574d818dbb6 > > commit 8278dff6a742c391f7c04c3de1033574d818dbb6 > Author: woochan lee <wc0917....@samsung.com> > Date: Thu May 28 20:39:32 2015 +0900 > > Spinner: Add changed callback call when spinner value set. > > Summary: > There is a code to compare value is changed. > 1256: if (sd->val == val) return; > > Even value changed the value changed callback didn't called before. > > Reviewers: woohyun, shilpasingh, Hermet > > Reviewed By: shilpasingh, Hermet > > Differential Revision: https://phab.enlightenment.org/D2560 > --- > src/lib/elm_spinner.c 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c > index 9624380..b306e87 100644 > --- a/src/lib/elm_spinner.c > +++ b/src/lib/elm_spinner.c > @@ -1268,6 +1268,7 @@ _elm_spinner_value_set(Eo *obj, Elm_Spinner_Data > *sd, double val) > } > _val_set(obj); > _label_write(obj); > + evas_object_smart_callback_call(obj, SIG_CHANGED, NULL); > } > > EOLIAN static double > > -- > > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
