I'm fine with this solution, though my preference would have been to revert it after the internal changes had gone in so that the errors would be gone for the interim.
On Mon, Jun 22, 2015 at 10:11 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Mon, 22 Jun 2015 18:00:38 -0400 Michael Blumenkrantz > <michael.blumenkra...@gmail.com> said: > > > On Mon, 22 Jun 2015 21:12:09 +0100 > > Daniel Kolesa <dan...@octaforge.org> wrote: > > > > > On Mon, Jun 22, 2015 at 7:55 PM, Mike Blumenkrantz > > > <zm...@osg.samsung.com> wrote: > > > > discomfitor pushed a commit to branch master. > > > > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=1edb35fff3fe54ac7eea1ba2c26e509284b4e470 > > > > > > > > commit 1edb35fff3fe54ac7eea1ba2c26e509284b4e470 > > > > Author: Mike Blumenkrantz <zm...@osg.samsung.com> > > > > Date: Mon Jun 22 14:53:13 2015 -0400 > > > > > > > > edje: unset efreet cache update flag to prevent dbus connections > > > > > > > > efreet_init began to be called with the addition of translatable > > > > strings, but allowing dbus connections in edje (and thus edje-derived > > > > tools) will result in errors when edje_init is called without a dbus > > > > connection available > > > > --- > > > > src/lib/edje/edje_main.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/src/lib/edje/edje_main.c b/src/lib/edje/edje_main.c > > > > index 03c46ea..a891ec5 100644 > > > > --- a/src/lib/edje/edje_main.c > > > > +++ b/src/lib/edje/edje_main.c > > > > @@ -1,5 +1,6 @@ > > > > #include "edje_private.h" > > > > > > > > +extern int efreet_cache_update; > > > > > > I believe doing this kind of stuff is a very bad idea... I'd look for > > > a different solution. Arbitrarily externing symbols like this is > > > something we should never do. > > > > > > D5 > > > > > > > I'm open to suggestions. > > i think the solution is to make efreet not complain so loudly if it can't > find > dbus services. > > actually efreet as well as thumb imho create way too much trouble using > dbus > services as an INTERNAL library communication mechanism (between daemons > and > library clients). just having to deal with the .service files creates a > lot of > user friction - esp those that compile as these files are installed in > PREFIX > and dbus isn't looking there. it ALSO means these libraries are only > partially > working outside of a dbus session. that makes efreet and ethumb useless on > systems without dbus or where they may be used on a system daemon. > > imho for now live with this noise (revert this) and i'll look at fixing > efreet > and thumb up to not depend on dbus. debus makes sense when you are > creating a > PUBLIC service you expect others to connect to and talk to. for an internal > feature it makes much less sense given the pain points. > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
