On Fri, Jun 26, 2015 at 12:05 PM, Daniel Kolesa <dan...@octaforge.org> wrote:
> On Fri, Jun 26, 2015 at 11:01 AM, Jorge Luis Zapata Muga > <jorgeluis.zap...@gmail.com> wrote: > > On Fri, Jun 26, 2015 at 11:50 AM, Tom Hacohen <t...@osg.samsung.com> > wrote: > > > >> On 26/06/15 00:42, Carsten Haitzler wrote: > >> > On Thu, 25 Jun 2015 18:01:36 +0100 Tom Hacohen <t...@osg.samsung.com> > >> said: > >> > > >> >> On 22/06/15 15:42, Tom Hacohen wrote: > >> >>> As I said in the commit message, why is the alternative logging > >> >>> mechanism even there? Shouldn't it be removed and we just always > rely > >> on > >> >>> eina log? > >> >> > >> >> No comments anyone? > >> > > >> > personally i find eina log output painful. mostly because its long. it > >> goes > >> > > >> > from this long > >> > > >> > to a a line this long and full of other stuff including escapes and > what > >> not so > >> > it eventually wraps around at least 2 lines in a standard 80 wide > >> terminal > >> > > >> > the escapes literally come up horribly: > >> > > >> > ESC[31mERR<ESC[0meoESC[31m>ESC[0mlib/eo/eo.c:780ESC[0m in > >> > lib/edje/edje_object.eo.c:420: unable to resolve regular api func > >> > 'edje_obj_thaw' 0x7efc4ff8c7d0 in class 'Evas_Rectangle'. > >> > > >> > literally that is what i get when i less my .xsession-errors. > >> > > >> > >> This is easy to fix. We should just make eina not print the escapes > >> when the output is a file... Super simple. Also, we could have a special > >> > > > > You can use the envvar EINA_LOG_ENV_COLOR_DISABLE if you dont want to > print > > colors. Please don't change eina's log behaviour for files. > > Why not? Colorization is useless and counter-productive in files. Just > check isatty and > determine whether colorization is enabled with that. > That's subjective. Why would it be counter-productive? Because you can not actually see the colors when reading the file? Use a pager that supports ansi color sequences, in less with the -R argument. If you dont want to print the colors because you dont want to, just pass the envvar and that's it. Eina's log already has all the functionality to meet your needs, there's no need to remove something generic because you always use the specific case. > > > > > > >> formatter that does simple print. It's nice having the different log > >> levels and it's the mechanism we use. It's stupid to have two different > >> mechanisms. > >> > >> -- > >> Tom. > >> > >> > >> > ------------------------------------------------------------------------------ > >> Monitor 25 network devices or servers for free with OpManager! > >> OpManager is web-based network management software that monitors > >> network devices and physical & virtual servers, alerts via email & sms > >> for fault. Monitor 25 devices for free with no restriction. Download now > >> http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > ------------------------------------------------------------------------------ > > Monitor 25 network devices or servers for free with OpManager! > > OpManager is web-based network management software that monitors > > network devices and physical & virtual servers, alerts via email & sms > > for fault. Monitor 25 devices for free with no restriction. Download now > > http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Monitor 25 network devices or servers for free with OpManager! > OpManager is web-based network management software that monitors > network devices and physical & virtual servers, alerts via email & sms > for fault. Monitor 25 devices for free with no restriction. Download now > http://ad.doubleclick.net/ddm/clk/292181274;119417398;o > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
