Hello.

On 07/08/15 07:46, Jee-Yong Um wrote:
> hermet pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=36dd11e8d6fb307df5f96444e64b7cf67e425169
>
> commit 36dd11e8d6fb307df5f96444e64b7cf67e425169
> Author: Jee-Yong Um <jc9...@samsung.com>
> Date:   Fri Aug 7 14:45:47 2015 +0900
>
>      edje_container: fix typo in edje_container_align_set
>
>      Summary:
>      Fix type in edje_container_align_set,
>      it was originally named as edje_contain(t)er_align_set.
>
>      Reviewers: Hermet
>
>      Subscribers: cedric, Hermet
>
>      Differential Revision: https://phab.enlightenment.org/D2927
> ---
>   src/lib/edje/edje_container.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/edje/edje_container.c b/src/lib/edje/edje_container.c
> index 6bf428f..30d0df5 100644
> --- a/src/lib/edje/edje_container.c
> +++ b/src/lib/edje/edje_container.c
> @@ -692,7 +692,7 @@ edje_container_max_size_get(Evas_Object *obj, Evas_Coord 
> *maxw, Evas_Coord *maxh
>   }
>
>   void
> -edje_containter_align_set(Evas_Object *obj, double halign, double valign)
> +edje_container_align_set(Evas_Object *obj, double halign, double valign)
>   {
>      Smart_Data *sd;
>

I was wondering why nothing else had to be changed when a function name 
changes. Turns out the whole content of edje_container.c is inside an 
#ifdef 0. At least since we merged libs for 1.8 but most likely long 
before. Why do we still have it in tree? Any good reason to keep it?

regards
Stefan Schmidt

------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to