2015-08-10 17:44 GMT+02:00 Stephen Houston <smhousto...@gmail.com>:

> Thanks Davide, got it working between elm_icon_order_lookup_set and
> elm_toolbar_icon_order_lookup_set ... However I think the point still
> stands that the default order should be FDO_THEME not THEME_FDO ... though
> with the necessary api in place I guess it is not that big of a deal....
> other than it would save a lines of code in most everyone's applications
> because 99% of people will be expecting/wanting FDO_THEME not THEME_FDO.
>

Ok, let me elaborate a bit more on this.

1. The FDO icon-theme:

At the moment elementary choose the fdo icon-theme to use looking at the
env var "E_ICON_THEME". This var is setted by E on startup and follow the
choice of the
user in the E configuration... what does this means? it means that when
your elm
app run outside E elm don't know what fdo theme to use and fallback to some
defaults.

This is completly wrong, it was done in this way when E was not elm based.
The logic should be the exact opposite now: elm should store the fdo
configuration
and E should read the config from elm.

So we must implement in elm_config 2 new values: the icon theme to use and
the
preferred lookup order. Of course also the elm_config binary must be
updated to
let the user make the choiches. Then we need to modify E itself to use the
new
values from elm.

2. The icons provided in the default theme:

Currently elm provide very few icons in the default theme, this really need
improvements, we should provide a quite-full icon theme.
Do we have the man-power to draw a full ORIGINAL icon theme? no, we don't,
and the actual situation prove it. So I really think we should import an
existing theme in elm, I'm going to propose 2 themes that can be easily
imported:

 * Gnome symbolic icons: this is a monochromatic theme (light or dark)
    http://noosfero.org/pub/Development/ActionItem3002/gnome-sym-icons.png
    https://github.com/GNOME/gnome-icon-theme-symbolic

 * The bluish version of the gnome one converted by wfx:
    https://github.com/wfx/eicons

Basically they are the same theme, in white, black, or bluish style, we
just need to
choose which one we prefer (my vote goes to the black one).

If we will find a deal I will find the time to do this import work.

3. Default lookup method to FDO->E or E->FDO

I think the default should be E->FDO, basically for a matter of speed:
loading an
icon from the default.edj file is not comparable in time with a freedesktop
lookup+
file icon load. For example in my system, I use a fdo theme that is quite
fully
svg based, the result is that opening an elm menu with 10 icons can take
more
that 1 second.

Btw, if we implement the point #1 this will be a user choice, thus not
really a
point of discussion :)

cheers
davemds




>
> On Mon, Aug 10, 2015 at 10:13 AM, Davide Andreoli <d...@gurumeditation.it>
> wrote:
>
> > the short answer is the function:
> >
> > elm_icon_order_lookup_set()
> >
> >
> https://docs.enlightenment.org/auto/elementary/group__Icon.html#gac0ca5b243d33619cdf9733b7b3be5100
> >
> > and give a look at the "Icon Standard" in elementary_test
> >
> > ...I will elaborate more in a second mail
> >
> > 2015-08-10 17:05 GMT+02:00 Jeff Hoogland <jeffhoogl...@linux.com>:
> >
> > > I'd like to second how backwards this behavior is. I've even gone as
> far
> > as
> > > to use slightly different icon names that aren't present in elementary
> in
> > > my applications to avoid this annoyance.
> > >
> > > On Mon, Aug 10, 2015 at 9:53 AM, Stephen Houston <
> smhousto...@gmail.com>
> > > wrote:
> > >
> > > > I'm sure this has been discussed before but I feel the need to bring
> it
> > > up
> > > > again.
> > > >
> > > > It is super annoying that when requesting a standard icon, you will
> > > always
> > > > get the blue icon from Elementary first if it exists, and then it
> falls
> > > > back on the icon theme.  I feel like this should be exactly the
> > opposite.
> > > > Check the icon theme first and fallback on Elementary's blue icons if
> > the
> > > > user's icon theme doesn't have the requested standard icon.
> > > >
> > > > For instance:
> > > > http://www.enlightenment.org/ss/e-55c4c1af28ccf5.97362633.jpg
> > > >
> > > > The blue slideshow icon is out of place here.  It should go with the
> > icon
> > > > theme first instead of finding that icon in Elementary.
> > > >
> > > > Thoughts?
> > > >
> > > >
> > >
> >
> ------------------------------------------------------------------------------
> > > > _______________________________________________
> > > > enlightenment-devel mailing list
> > > > enlightenment-devel@lists.sourceforge.net
> > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > > >
> > >
> > >
> > >
> > > --
> > > ~Jeff Hoogland <http://jeffhoogland.com/>
> > > My Projects on GitHub <https://github.com/JeffHoogland>
> > >
> > >
> >
> ------------------------------------------------------------------------------
> > > _______________________________________________
> > > enlightenment-devel mailing list
> > > enlightenment-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > >
> >
> >
> ------------------------------------------------------------------------------
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> >
>
> ------------------------------------------------------------------------------
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to