I set the value experimentally. At least, in my test case, it was over the PATH_MAX(256) but not less than 512. If you think it should be more than 1024 then increase it please.
I just realized it's useless but let's see exe_cmd_buf can be removed or not. ------------------------------------ -Regards, Hermet- -----Original Message----- From: "Davide Andreoli"<d...@gurumeditation.it> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; Cc: <g...@lists.enlightenment.org>; Sent: 2015-08-29 (토) 18:52:45 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore win32: increase command buffer size. 2015-08-29 10:00 GMT+02:00 ChunEon Park <her...@hermet.pe.kr>: > hermet pushed a commit to branch master. > > > http://git.enlightenment.org/core/efl.git/commit/?id=d71182af7a3c787b30cd6a5747b9d5f055fee003 > > commit d71182af7a3c787b30cd6a5747b9d5f055fee003 > Author: ChunEon Park <her...@hermet.pe.kr> > Date: Sat Aug 29 16:59:19 2015 +0900 > > ecore win32: increase command buffer size. > > PATH_MAX is not enough for command. > Even in this case, the buffer is not being used only for path. > hmm, are you sure about this? did you tested in some way? do this really solve something? 1024 seems not enough to me, I use longer commands in epymc also looking at the function code seems that exe_cmd_buf is not used in any way, apart from being filled and truncated :/ > --- > src/lib/ecore/ecore_exe_win32.c 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/ecore/ecore_exe_win32.c > b/src/lib/ecore/ecore_exe_win32.c > index 6e6226c..f03b05b 100644 > --- a/src/lib/ecore/ecore_exe_win32.c > +++ b/src/lib/ecore/ecore_exe_win32.c > @@ -362,7 +362,7 @@ _impl_ecore_exe_run_priority_get(void) > Eo * > _impl_ecore_exe_eo_base_finalize(Eo *obj, Ecore_Exe_Data *exe) > { > - char exe_cmd_buf[PATH_MAX]; > + char exe_cmd_buf[1024]; > SECURITY_ATTRIBUTES sa; > STARTUPINFO si; > PROCESS_INFORMATION pi; > > -- > > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
