I see there's EINA_LOG_BACKTRACE. Is it possible to disable the backtrace in configure? I would love that. Or is there at least a way to disable it with an env var?
With that being said, I agree it's very useful to have it on by default so users and distros have it. -- Tom On 04/10/15 10:12, Carsten Haitzler wrote: > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=dad345e574efec29c1f686b371fc72491a3f5c47 > > commit dad345e574efec29c1f686b371fc72491a3f5c47 > Author: Carsten Haitzler (Rasterman) <[email protected]> > Date: Sun Oct 4 17:56:07 2015 +0900 > > Revert "eina: change default log level at which we display backtrace." > > This reverts commit 05c18876b3e2dba5dd7caea2517aaf24d92ab614. > > i endabled backtraces by DEFAULT because it is otherwise pretty damned > hard to get them from things like enlightenment, or on tizen apps as > running them on the cmdline and having them work is close to > impossible. yes it's noise. FIX THE ERRORS then. this commit is just > like turning off gcc etc. warnings because the code is too noisy in > compilation with them on. it's a bug. fix it. the bt lets you do that > without gdb or re-executing AGAIN with an env var and HOPING to find > the bug the next time around. > > not to mention efl programming docs cover this backtrace and say it > is on by default and how to get useful info out of this. this makes > the elf docs a lie by removing what is documented as default. > > @fix > --- > src/lib/eina/eina_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/eina/eina_log.c b/src/lib/eina/eina_log.c > index a9eb9aa..6fc9626 100644 > --- a/src/lib/eina/eina_log.c > +++ b/src/lib/eina/eina_log.c > @@ -121,7 +121,7 @@ static Eina_Bool _disable_timing = EINA_TRUE; > static int _abort_level_on_critical = EINA_LOG_LEVEL_CRITICAL; > > #ifdef EINA_LOG_BACKTRACE > -static int _backtrace_level = 1; // CRI & ERR by default > +static int _backtrace_level = 2; // CRI & ERR by default > #endif > > static Eina_Bool _threads_enabled = EINA_FALSE; > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
