Hello.
On 21/10/15 14:57, Jaehwan Kim wrote:
> jaehwan pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=b1fa1c5aadc71881cb1e4e264d680ea5efa79a69
>
> commit b1fa1c5aadc71881cb1e4e264d680ea5efa79a69
> Author: Jaehwan Kim <[email protected]>
> Date: Wed Oct 21 21:51:54 2015 +0900
>
> edje: add edje signal emit about swallow, text
>
> Add the edje signal "swallow", "unswallow", "text,set", "text,unset".
> In edc file, the part name take a role of source.
> If the layout should be changed when any object is swallowed or any
> text is set, use this signal.
>
> @feature
You realise that we are in feature freeze and stabilization phase right now?
This commit is even marked as new feature. Why did you put it in?
regards
Stefan Schmidt
> ---
> src/lib/edje/edje_util.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c
> index aa77208..6ef5d60 100644
> --- a/src/lib/edje/edje_util.c
> +++ b/src/lib/edje/edje_util.c
> @@ -1442,6 +1442,10 @@ _edje_object_part_text_raw_set(Edje *ed, Evas_Object
> *obj, Edje_Real_Part *rp, c
> _edje_recalc(ed);
> if (ed->text_change.func)
> ed->text_change.func(ed->text_change.data, obj, part);
> + if (text)
> + _edje_emit(ed, "text,set", rp->part->name);
> + else
> + _edje_emit(ed, "text,unset", rp->part->name);
> return EINA_TRUE;
> }
>
> @@ -2886,6 +2890,7 @@ _edje_object_part_swallow(Eo *obj EINA_UNUSED, Edje
> *ed, const char *part, Evas_
> eud->u.swallow.child = obj_swallow;
> }
> }
> + _edje_emit(ed, "swallow", rp->part->name);
>
> return EINA_TRUE;
> }
> @@ -3162,6 +3167,7 @@ _edje_object_part_unswallow(Eo *obj EINA_UNUSED, Edje
> *ed, Evas_Object *obj_swal
> if (eud->type == EDJE_USER_SWALLOW &&
> eud->u.swallow.child == obj_swallow)
> {
> _edje_user_definition_free(eud);
> + _edje_emit(ed, "unswallow", rp->part->name);
> return;
> }
> }
> @@ -3182,6 +3188,7 @@ _edje_object_part_unswallow(Eo *obj EINA_UNUSED, Edje
> *ed, Evas_Object *obj_swal
> * -zmike, 6 April 2015
> */
> //_edje_recalc_do(ed);
> + _edje_emit(ed, "unswallow", rp->part->name);
> return;
> }
> }
>
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
