On Sun, Oct 25, 2015 at 9:23 AM, Davide Andreoli <[email protected]> wrote: > 2015-10-23 7:20 GMT+02:00 Conrad Um <[email protected]>: >> I'm sorry for inconvenience in using scrollable hoversel. >> >> Davide metioned that scrollable hoversel should be expand as large as it >> can, but becomes scrollable after its size exceeds hover parent size. >> >> >> To say the conclusion first, that function is already implemented. >> >> If "max_size" is large enough, hoversel will try expanding to the >> "max_size", and shrinks again to fit its parent size. >> >> I thought that developers would determine how many items will show at the >> same time and customize theme, but it could be a cumbersome for those who >> do not want customize theme. >> >> >> The next patch removes the limitation with pixels, and makes hoversel >> expand as large as it can, but shrinks to fit its hover parent. >> >> https://phab.enlightenment.org/D3223 > > > Cool, thanks, this differential fix my use case. > At this point I wonder if we need the scrollable_set/get API at all, > souldn't it be scrollable all the time (when it does not fit)? > Is there a use case where you want it to be not scrollable?
Preparing to push it. Now I agree here with your concern about scrollable_get/set. Do we really need it at all for any reason ? If that is part of the API added in 1.16, I think we should remove it. >> regards, >> >> Jee-Yong Um >> >> >> 2015년 10월 23일 금요일, Davide Andreoli<[email protected]>님이 작성한 메시지: >> >> > Let me try to explain better the problematic with the hoversel scrollable >> > implementation. >> > I will use some egitu screenshots to show a real case usage. >> > >> > This is clearly a case where hoversel scrollable is needed: >> > http://imgbin.org/images/27048.jpg >> > as you can see the list of branches (on the right) is too big to fit >> > in the window, thus the hoversel need to be set as scrollable. >> > >> > Now I set the hoversel to be scrollable.. this is the result: >> > http://imgbin.org/images/27049.jpg >> > as you can see the hoversel is way to short (60px fixed in theme), >> > and totally unusable as the scrolling is way to fast and finding the >> > wanted item is pratically impossible. >> > >> > What we really want here is that the scrollable hoversel expand its size >> > to the maximun size available in the hover_parent obj (or the maximum >> > size of its contents if fit). >> > >> > To conclude I think this will need to be fixed (or reverted) in time for >> > the release, as it will be a mess to fix in a later time. Also remember >> > that this change (as it is now) require all the elm themes to be updated, >> > an thus re-updated if we will fix later. >> > >> > >> > >> > 2015-10-21 17:24 GMT+02:00 Stefan Schmidt <[email protected] >> > <javascript:;>>: >> > >> > > Hello Jee-Yong Um. >> > > >> > > On 07/10/15 20:22, Davide Andreoli wrote: >> > > > 2015-08-04 16:59 GMT+02:00 Jee-Yong Um <[email protected] >> > <javascript:;>>: >> > > > >> > > >> cedric pushed a commit to branch master. >> > > >> >> > > >> >> > > >> >> > > >> > >> http://git.enlightenment.org/core/elementary.git/commit/?id=e8264becb8f6f36e3c62c5fc5e4a46bbdbb9cf1f >> > > >> >> > > >> commit e8264becb8f6f36e3c62c5fc5e4a46bbdbb9cf1f >> > > >> Author: Jee-Yong Um <[email protected] <javascript:;>> >> > > >> Date: Tue Aug 4 15:51:36 2015 +0200 >> > > >> >> > > >> elm_hoversel: add elm_hoversel_scroll_enabled_set/get() API >> > > >> >> > > >> Summary: >> > > >> Currently, hoversel shows all items at the same time, but to >> > limit >> > > >> the size of contents and make it scrollable is neccesary to >> some >> > > users. >> > > >> elm_hoversel_scroll_enabled_set/get() API makes the contents of >> > > >> hoversel >> > > >> scrollable or not. >> > > >> >> > > > Surly a must-have feature (I also need the hoversel to be scrollable >> in >> > > > egitu). >> > > > >> > > > But I really don't like the behaviour of this implementation: the >> usage >> > > of >> > > > the max_size >> > > > in edc seems wrong to me. >> > > > Now if you want the hover to be scrollable you end up with a really >> > > > small popup: 60 fixed px from the theme... Is this the wanted >> > behaviour? >> > > > how can >> > > > a theme designer know how many pixel are needed? >> > > > >> > > > I think that a "correct" implementation should expand the popup to >> the >> > > > maximum >> > > > available space and then use the scroller if it still do not fit. >> > > > >> > > > The current implementation is unusable in my case: >> > > > I have an hover that can contain up to (for example) 200 items, and >> if >> > I >> > > > set it scrollable >> > > > it only show 2 items at a time...really unusable... >> > > > >> > > >> > > Can you please comment on what Davide brings up here about your commit? >> > > >> > > regards >> > > Stefan Schmidt >> > > >> > > >> > > >> > >> ------------------------------------------------------------------------------ >> > > _______________________________________________ >> > > enlightenment-devel mailing list >> > > [email protected] <javascript:;> >> > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > > >> > >> > >> ------------------------------------------------------------------------------ >> > _______________________________________________ >> > enlightenment-devel mailing list >> > [email protected] <javascript:;> >> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
