On 27/11/15 11:17, Amitesh Singh wrote: > Hello > On Nov 27, 2015 4:02 PM, "Amitesh Singh" <[email protected]> wrote: >> >> Hello >> >> On Nov 23, 2015 11:02 PM, "Mike Blumenkrantz" < > [email protected]> wrote: >>> >>> discomfitor pushed a commit to branch master. >>> >>> > http://git.enlightenment.org/core/elementary.git/commit/?id=bb389fc9af335f4916780812ace7273d64e8bceb >>> >>> commit bb389fc9af335f4916780812ace7273d64e8bceb >>> Author: Mike Blumenkrantz <[email protected]> >>> Date: Mon Nov 23 12:26:57 2015 -0500 >>> >>> table: implement Evas.Object_Smart.calculate >>> >>> this allows tables to be manually calculated >>> >>> ref T2836 >>> --- >>> src/lib/elm_table.c | 8 ++++++++ >>> src/lib/elm_table.eo | 1 + >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/src/lib/elm_table.c b/src/lib/elm_table.c >>> index 1a4d01a..ed1a906 100644 >>> --- a/src/lib/elm_table.c >>> +++ b/src/lib/elm_table.c >>> @@ -407,4 +407,12 @@ _elm_table_class_constructor(Eo_Class *klass) >>> evas_smart_legacy_type_register(MY_CLASS_NAME_LEGACY, klass); >>> } >>> >>> +EOLIAN void >>> +_elm_table_evas_object_smart_calculate(Eo *obj, void *pd EINA_UNUSED) >>> +{ >>> + ELM_WIDGET_DATA_GET_OR_RETURN(obj, wd); >>> + >>> + evas_object_smart_calculate(wd->resize_obj); >>> +} >>> + >> >> I think this should be done for all widgets. >> Better to place it at Elm_widget.calculate ()? >> >> If you agree, I will add it in Elm widget. >> > Okay. I understood why you added this code to Elm table only. > In some widgets, there are few sub objects other than resize obj so smart > calculate needs to be applied on others too.
Exactly. Resize object happens to work for this one, but it doesn't mean it'll work for all. > >>> #include "elm_table.eo.c" >>> diff --git a/src/lib/elm_table.eo b/src/lib/elm_table.eo >>> index 2793f35..9d2ae65 100644 >>> --- a/src/lib/elm_table.eo >>> +++ b/src/lib/elm_table.eo >>> @@ -120,6 +120,7 @@ class Elm.Table (Elm.Widget) >>> Eo.Base.constructor; >>> Evas.Object_Smart.add; >>> Evas.Object_Smart.del; >>> + Evas.Object_Smart.calculate; >>> Elm.Widget.focus_direction; >>> Elm.Widget.focus_next_manager_is; >>> Elm.Widget.focus_next; >>> >>> -- >>> >>> > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
