2015-12-20 17:13 GMT+01:00 Mike Blumenkrantz <michael.blumenkra...@gmail.com >:
> I've resolved this with > > https://git.enlightenment.org/core/elementary.git/commit/?id=36748107dabcebb148193548a31095cb8adfc9aa > > When pushing/reviewing patches that add null checks in the future, let's > try to be a bit more careful so that we don't accidentally break existing > features like this. > Indeed we absolutly need to be more careful to the "gray area behavior breaks" that we continuosly make in our libs. On every new stable release I need to recheck and fix all my apps. This IMO is going to be a big wall in the spread of efl and efl based apps. To be clear about the "break" mentioned on this thread: In epymc I was unsetting the elm_image content using something like: elm_image_file_set(img, "") [an empty string] This was probably not really correct, but it worked for the past 5 years (or so). Using this method the image was cleared of his contents and the function was returning TRUE as a successfull operation (probably not correct also). Now instead (also after the zmike reverts) the function return FALSE as a failure and throw some errors on console. I fixed my media center by completly delete the image object when no contents are to be displayed, and then recreate and swallow again a new object when needed. Sadly this means that if a user upgrade the efl he/she will end up with a partially broken media center, unless he/she also upgrade epymc (and this will impose me to make a new fast fixing release of my app in the next few days). I do not want to discuss if the previous behaviour was correct or not, my primary concern is that the behaviour has changed at some point between the stable releases, braking the functionality of my app. IMO we should be more conservative on the behaviour of our API, also in the cases of stuff considered wrong (like is probably the case here). To conclude, and to make all of you aware of my sadness state: I'm seriously considering to rewrite epymc using another (more stable) toolkit :( > > On Sun, Dec 20, 2015 at 5:47 AM Davide Andreoli <d...@gurumeditation.it> > wrote: > > > Arghh!! something changed in elm_image_file_set() in the 1.16 release. > > > > I used to set the file as a empty string to UNSET the image, > > but now setting an empty string make the function return error > (EINA_FALSE) > > and leave the image content as is. While it was working as "expected" and > > returning TRUE in older release. > > > > Is there a way to UNSET an image now? > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
