Hello Mike

On Jan 7, 2016 3:40 AM, "Mike Blumenkrantz" <michael.blumenkra...@gmail.com>
wrote:
>
> discomfitor pushed a commit to branch master.
>
>
http://git.enlightenment.org/core/elementary.git/commit/?id=92481addac649391cd97d73f384dfe23603a4c87
>
> commit 92481addac649391cd97d73f384dfe23603a4c87
> Author: Mike Blumenkrantz <zm...@osg.samsung.com>
> Date:   Wed Jan 6 17:05:44 2016 -0500
>
>     widget: check next_item existence when focusing before calling widget
fns
>
>     ERR<eo>lib/eo/eo.c:753 Unable to resolve op for api func
0x7ffff7cc17ce
> ---
>  src/lib/elm_widget.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lib/elm_widget.c b/src/lib/elm_widget.c
> index f917d29..97ef045 100644
> --- a/src/lib/elm_widget.c
> +++ b/src/lib/elm_widget.c
> @@ -2432,7 +2432,8 @@ _elm_widget_focus_next_get(const Eo *obj,
Elm_Widget_Smart_Data *sd, Elm_Focus_D
>                 *next_item = sd->item_focus_right;
>               else if (dir == ELM_FOCUS_LEFT)
>                 *next_item = sd->item_focus_left;
> -             o = elm_object_item_widget_get(*next_item);
> +             if (*next_item)
> +               o = elm_object_item_widget_get(*next_item);
>
Thanks for the fix. This eo error was annoying for sometime and I noticed
it on day before yesterday when I was implementing a feature related to
focus.(this error comes when there is no next focusable object). Now I know
why eo was complaining about it. I knew it is related to some logic on
finding next object item and possibly next was null as the same error does
not come in case of prev focusable item (e.g. alt-tab..)
Unfortunately, I could not able to trace it as eo error was not giving much
information.  It would be super nice if you share how did you know the root
point. This would help others in future to hunt down similar problems in
future.

>               if (!o)
>                 {
>
> --
>
>
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to