2016-01-08 12:53 GMT+01:00 Hermet Park <her...@hermet.pe.kr>: > hermet pushed a commit to branch master. > > > http://git.enlightenment.org/core/elementary.git/commit/?id=e52126c004843f865d50649a5be9e7d9f305ef92 > > commit e52126c004843f865d50649a5be9e7d9f305ef92 > Author: Hermet Park <her...@hermet.pe.kr> > Date: Fri Jan 8 20:50:01 2016 +0900 > > hoversel: don't activate if the items were none. > > it's wierd to expand hoversel without items. > the behavior made me suprised before i analyzed it. > it looked almost a bug. > > if you have any other objections, please ping me. >
I'm absolutely not sure (not readed the code) but maybe it was possible to fill/add items when the user click on the widget? Is this still possible? > --- > src/lib/elc_hoversel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib/elc_hoversel.c b/src/lib/elc_hoversel.c > index 51625da..175e1fb 100644 > --- a/src/lib/elc_hoversel.c > +++ b/src/lib/elc_hoversel.c > @@ -421,6 +421,7 @@ _activate(Evas_Object *obj) > sd->expanded = EINA_TRUE; > > if (elm_widget_disabled_get(obj)) return; > + if (!sd->items) return; > > sd->hover = elm_hover_add(sd->hover_parent); > elm_widget_sub_object_add(obj, sd->hover); > @@ -794,7 +795,6 @@ _elm_hoversel_item_add(Eo *obj, Elm_Hoversel_Data *sd, > const char *label, const > snprintf(buf, sizeof(buf), "hoversel_vertical_entry/%s", > elm_widget_style_get(obj)); > > - > VIEW(item) = bt = elm_button_add(obj); > elm_widget_mirrored_set(bt, elm_widget_mirrored_get(obj)); > elm_object_style_set(bt, buf); > > -- > > > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
