Hello. On 14/01/16 16:14, Tom Hacohen wrote: > On 14/01/16 14:55, Stefan Schmidt wrote: >> stefan pushed a commit to branch master. >> >> http://git.enlightenment.org/core/elementary.git/commit/?id=6b84a60928fcdc57f035a22af783355a139b1819 >> >> commit 6b84a60928fcdc57f035a22af783355a139b1819 >> Author: Stefan Schmidt <ste...@osg.samsung.com> >> Date: Thu Jan 14 15:53:53 2016 +0100 >> >> elm_config: print an eror message if we fail to save the derived >> config profile >> --- >> src/lib/elm_config.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/src/lib/elm_config.c b/src/lib/elm_config.c >> index 647679d..113c92c 100644 >> --- a/src/lib/elm_config.c >> +++ b/src/lib/elm_config.c >> @@ -780,8 +780,15 @@ _elm_config_profile_derived_save(const char *profile, >> Elm_Config_Derived *derive >> if (ef) >> { >> ret = eet_data_write(ef, _config_derived_edd, "config", derived, >> 1); >> + if (ret) >> + { >> + ecore_file_mv(buf, buf2); >> + } >> + else >> + { >> + ERR("Error saving Elementary's derived configuration profile >> file"); >> + } >> eet_close(ef); >> - if (ret) ecore_file_mv(buf, buf2); >> } >> } >> >> > Thanks, though one more comment: is it a good idea to move the file > before you closed it? I'd expect a flush to happen only on close, even > if not now, in the future.
Its not a good idea and it was correct before my change. A bit embarrassing that I need three commits here. Anyway, fixed now as well. Last commit for today... regards Stefan Schmidt ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
