On 21 January 2016 at 19:27, Stefan Schmidt <[email protected]> wrote:
> Hello. > > On 21/01/16 03:25, Jean-Philippe André wrote: > > On 20 January 2016 at 23:58, Cedric BAIL <[email protected]> wrote: > > > >> On Jan 20, 2016 00:07, "Minkyu Kang" <[email protected]> wrote: > >>> hermet pushed a commit to branch master. > >>> > >>> > >> > http://git.enlightenment.org/core/elementary.git/commit/?id=2eb95a547736af1445b0a292223ad8973ad24acb > >>> commit 2eb95a547736af1445b0a292223ad8973ad24acb > >>> Author: Minkyu Kang <[email protected]> > >>> Date: Wed Jan 20 17:06:22 2016 +0900 > >>> > >>> elm_widget: cleanup _elm_widget_on_focus function > >>> > >>> Summary: > >>> This patch will reduce duplicate codes and code depth for > readability > >>> > >>> Signed-off-by: Minkyu Kang <[email protected]> > >>> > >>> Reviewers: seoz, Hermet, cedric > >>> > >>> Subscribers: seoz > >> I will let Stefan have his call here, but this commit doesn't look like > a > >> fix to me and does change a substantial amount of line we have no > automated > >> tests for. > >> > > It looks a lot like a simple cleanup to me. The logic looks unchanged to > me. > > > > IMHO the point it more about timing. We have 11 days left before 1.17 > should go out. I would prefer if people would look at the work items I > posted and go through the bugtracker to find things that need to be > fixed. Especially Elementary gets more and more bug reports with little > people working on them upstream. > > Cleanup patches like this are indeed very welcome to remove code > duplication and ease maintenance. But I really see no good reason why > they could not have waited for 12 more days before they land. > > I looked at both patches and I can't find any logic problems with the > re-factor either. Thus I'm not going to revert them but I'm not happy > about the timing of these. > <https://lists.sourceforge.net/lists/listinfo/enlightenment-devel> > OK. Makes sense :) -- Jean-Philippe André ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
