Hi again, On 1 February 2016 at 13:57, Jean-Philippe André <[email protected]> wrote:
> Hi, > > On 1 February 2016 at 06:04, Davide Andreoli <[email protected]> > wrote: > >> Hi all, >> >> I was not able to speak with noone in chat in the last days, so here is a >> last-minute-fix for Genlist/grid: >> >> https://phab.enlightenment.org/T3122 >> >> Patch is really simple, the problem is just a wrong cast that make the if >> statement always false. >> >> Please review and commit BEFORE the release, it is really important for >> me, >> or I will have to postpone my epymc release for other 3 months. >> >> THANKS!!!! >> > > The patch itself looks good. This is definitely fixing a bad casting issue. > > I can't merge this in because it reveals another bug in genlist. Unrelated > to your direct fix, but related to the items cache. > See my comments in the ticket. > > Maybe we can find a solution, if we accept to delay the release... > But you should probably first explain what was the issue on your side. > After more testing, and in particular testing Davide's app (epymc), I can definitely say that the fix is good, and the new issue I see has nothing to do with this fix. Also, it doesn't happen all the time, only sometimes. So I pushed this patch: 2ad850e99769c6cc0eb002a497bcfb4432132fa8 -- Jean-Philippe André ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
