On Tue, Feb 2, 2016 at 10:42 AM Tom Hacohen <[email protected]> wrote:
> On 02/02/16 13:17, Davide Andreoli wrote: > > 2016-02-02 12:23 GMT+01:00 Tom Hacohen <[email protected]>: > > > >> This makes the code significantly worse, why do this? > >> > > > > Not that I have a strong opinion on this, but declaration separated from > > code > > was part of some efl guidelines in the past. > > I also remember it was there at some point, though I can't see it now > (maybe it's still there?). > Either way, it was never relevant for those kinds of cases, i.e, we've > always declared variables after safety checks. The guidelines were ever > only about putting it deep inside the code. > > I plan on reverting it tomorrow if I don't hear anything back. > > -- > Tom. > > This is misleading; the vast majority of safety checks are indeed preceded by variable declarations--this has been the standard since before I joined the project and it continues to be the standard now despite attempts to sneak in code which is written differently. If the style guide does not reflect this then the style guide has either not been accurately carried over from past incarnations or was never updated for this specific type of case. ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
