------- Original Message ------- Sender : Davide Andreoli<[email protected]> Date : Feb 13, 2016 19:16 (GMT+09:00) Title : Re: [E-devel] [EGIT] [core/elementary] master 02/06: spinner: add min, max filter
2016-02-12 23:35 GMT+01:00 Cedric BAIL : > On Fri, Feb 12, 2016 at 9:51 PM, Davide Andreoli > wrote: > > 2016-02-12 21:30 GMT+01:00 Shilpa Singh : > >> > http://git.enlightenment.org/core/elementary.git/commit/?id=a3e66305d7601fa4a62629ec2ceb29a1af274915 > >> > >> commit a3e66305d7601fa4a62629ec2ceb29a1af274915 > >> Author: Shilpa Singh > >> Date: Fri Feb 12 20:38:36 2016 +0100 > >> > >> spinner: add min, max filter > >> > >> Summary: > >> In spinner's entry allow numbers only with in min/max range > >> Signed-off-by: Shilpa Singh > >> > >> @feature > >> > >> Test Plan: > >> 1. Set min/max value to spinner > >> 2. Enter numbers beyond min/max value > >> > > > > Is there a reason why this is only enabled in mobile profile? I cannot > > either see why this is configurable at all, seems to me that this check > > should be always on... no? > > Yes, we were not sure to not break current application that would have > hacked spinner in unexpected way. Ideally I agree it shouldn't be > optional, but as I wasn't convinced this is a first step. If you think > it is safe to turn on always, we should go ahead then. > I never used the spinner widget, so from my side no hack has been done. Also not respecting min/max seems really a bug to me. I vote for always on. This is more of a behavioral change and not exactly a bug hence its made configurable. min/max is considered even with out my patch but only while the value is getting committed to spinner and not while entering/typing the value so if we type a value larger than max, the value will get reset to max and if we type a value lesser than min, value will get reset to spin. Wth this patch we control the input while typing itself so we don't allow user to even type a value beyond min/max range few places I have seen that spinners allow any kind of value and only later, adjust the value before setting it. So I guess, its not a bad idea to keep this as a configurable feature. > -- > Cedric BAIL > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
